make audiobook organization recursive#56
Merged
JeremiahM37 merged 2 commits intoJun 2, 2026
Conversation
JeremiahM37
reviewed
Jun 1, 2026
| return os.Remove(src) | ||
| } | ||
|
|
||
| func moveDirTree(srcDir, dstDir string) error { |
Owner
There was a problem hiding this comment.
WalkDir doesn't follow directory symlinks (good), but a symlinked file inside a torrent will get dereferenced by moveFile's copy+delete fallback — that path uses ReadFile/WriteFile, so a symlink pointing at /etc/passwd would get copied into the audiobook library. Worth a d.Type()&os.ModeSymlink != 0 skip in the walk before moveFile is called.
1cda863 to
3875d9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes audiobook organization preserve nested directory trees instead of flattening only the top level.
What changed:
CD1/andCD2/Extras/layout.Why:
Validation:
go test ./internal/organizelibrarr:prowlarr-audiobooksimage.librarrcontainer.