Avoid name clash with RP Runtimes for remaining float functions#75
Merged
JeremyGrosser merged 1 commit intoMar 27, 2026
Merged
Conversation
This adds External_Name_Prefix for the remaining functions in RP.ROM.Floating_Point which are exported using External_Name to avoid clashing symbol names with the GNAT runtimes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #74 a prefix was added to exported symbols in
RP.ROM.Floating_Pointto avoid clashing with the same symbols provided by RP runtimes, but the fix was incomplete as not all exported functions were prefixed (e.g.sqrtf). This addsExternal_Name_Prefixto the remaining functions in that package.