Skip to content

pntr: Enable UTF-8 support#173

Draft
RobLoach wants to merge 1 commit into
JesseTG:devfrom
RobLoach:utf8
Draft

pntr: Enable UTF-8 support#173
RobLoach wants to merge 1 commit into
JesseTG:devfrom
RobLoach:utf8

Conversation

@RobLoach

@RobLoach RobLoach commented Feb 15, 2024

Copy link
Copy Markdown
Contributor

This enables UTF-8 characters for the default amount of glyphs. For CJK characters, we'd need to use a font that has them.

Screenshot_from_2026-02-25_21-29-12

@JesseTG

JesseTG commented Feb 16, 2024

Copy link
Copy Markdown
Owner

Thanks for working on this! Could you please retarget this against dev instead of main?

@RobLoach RobLoach changed the base branch from main to dev February 16, 2024 01:04
Comment thread src/libretro/message/error.cpp Outdated
@RobLoach

RobLoach commented Apr 22, 2024

Copy link
Copy Markdown
Contributor Author

Merged the PR 👍

Of course, I wouldn't recommend using PNTR_ENABLE_UTF8 until you actually need it.

@JesseTG

JesseTG commented Apr 24, 2024

Copy link
Copy Markdown
Owner

Merged the PR 👍

Of course, I wouldn't recommend using PNTR_ENABLE_UTF8 until you actually need it.

I look forward to giving it a whirl as soon as I'm ready to. Thanks Rob, I appreciate it a lot.

Comment on lines +37 to +39
static constexpr const char* const ERROR_TITLE = u8"Oh no! Добрий день!";
static constexpr const char* const SOLUTION_TITLE = u8"Here's do: 修复方法";
static constexpr const char* const THANK_YOU = u8"Thank you 谢谢您";

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore the original characters, instead of the demo ones.

Suggested change
static constexpr const char* const ERROR_TITLE = u8"Oh no! Добрий день!";
static constexpr const char* const SOLUTION_TITLE = u8"Here's do: 修复方法";
static constexpr const char* const THANK_YOU = u8"Thank you 谢谢您";
static constexpr const char* const ERROR_TITLE = "Oh no! melonDS DS couldn't start...";
static constexpr const char* const SOLUTION_TITLE = "Here's what you can do:";
static constexpr const char* const THANK_YOU = "Thank you for using melonDS DS!";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants