pntr: Enable UTF-8 support#173
Draft
RobLoach wants to merge 1 commit into
Draft
Conversation
Owner
|
Thanks for working on this! Could you please retarget this against |
RobLoach
commented
Apr 20, 2024
Contributor
Author
|
Merged the PR 👍 Of course, I wouldn't recommend using |
Owner
I look forward to giving it a whirl as soon as I'm ready to. Thanks Rob, I appreciate it a lot. |
RobLoach
commented
Feb 26, 2026
Comment on lines
+37
to
+39
| static constexpr const char* const ERROR_TITLE = u8"Oh no! Добрий день!"; | ||
| static constexpr const char* const SOLUTION_TITLE = u8"Here's do: 修复方法"; | ||
| static constexpr const char* const THANK_YOU = u8"Thank you 谢谢您"; |
Contributor
Author
There was a problem hiding this comment.
Restore the original characters, instead of the demo ones.
Suggested change
| static constexpr const char* const ERROR_TITLE = u8"Oh no! Добрий день!"; | |
| static constexpr const char* const SOLUTION_TITLE = u8"Here's do: 修复方法"; | |
| static constexpr const char* const THANK_YOU = u8"Thank you 谢谢您"; | |
| static constexpr const char* const ERROR_TITLE = "Oh no! melonDS DS couldn't start..."; | |
| static constexpr const char* const SOLUTION_TITLE = "Here's what you can do:"; | |
| static constexpr const char* const THANK_YOU = "Thank you for using melonDS DS!"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables UTF-8 characters for the default amount of glyphs. For CJK characters, we'd need to use a font that has them.