JBR-6612 Provide standard scripts for performance measurements #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation for linux and macOS
vprovodin
reviewed
Feb 19, 2024
Collaborator
vprovodin
left a comment
vprovodin
left a comment
There was a problem hiding this comment.
I would add comments at the beginning of the run scripts. At least it is required for run_inc.sh that looks like to be used as a copmound part of other run scripts and should not be launched directly - most probably it should be renamed (e.g. removing run-prefix) in order to avoid any confusions.
It should be also great to mention options in these comments that are valid for each launcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation for linux and macOS