JBR-9823 Allow open random access files to be deleted on Windows #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…slider is not rendered properly
It doesn't happen in any default implementation with default attribute classes, but some 3rd party implementations can do that.
A new behavior for java.io.File was introduced in commit 9477c70. For example, `new File("").exists()` returns true now, but it used to return false.
…RandomAccessFile.write
…est.java: Wrong GTK library version: null
-Increased rendering performance -Improved text rendering quality -Accelerated repainting during window resizing -Removed unnecessary fallback to GDI rendering -Eliminated unnecessary hardware limitations
Exclude VM error-reporting code that treats memory as a raw sequence of bytes from address sanitizer checks. This is needed to only get true reports when running tests against the --enable-asan build. (cherry picked from commit 4c2085b)
…ration with unexpected shortcuts on macOS
This patch implements support for the xdg_toplevel_icon_v1 protocol. The image choosing logic is just to pick the largest square image for now. The image scale factor is also not set, since it's unclear if it's needed and how it interacts with multi-monitor setups. NOTE: this patch introduces a dependency on wayland-protocols 1.37+.
Use getRootPane()
.putClientProperty("wlawt.popup_position_unconstrained", Boolean.TRUE)
to enable unconstrained popup positioning.
Clear native peer on windowClosing in Frame object (cherry picked from commit 441bb9d)
…use "this.wlSurface" is null
…untime/arguments.cpp at line 3878
…ion_nativeNotifyConfigured
…nputStream, RandomAccessFile, and FileOutputStream
The WinAPI function `GetFileAttributesW` actually opens a file and immediately closes it. If the file is a named pipe, it triggers a connection to the listener of the pipe. The listener closes the connection also asynchronously.
If the pipe is created with `nMaxInstances=1`, this code does not work:
```java
var path = Path.of("""\\.\pipe\openssh-ssh-agent""")
// `readAttributes` calls `GetFileAttributesW`, it opens the file and then closes it.
if (Files.readAttributes(path, BasicFileAttributes.class).isRegularFile()) {
// Very probable race condition: the listener of the pipe has already received
// the request of opening the file triggered by `GetFileAttributesW`
// but hasn't closed the connection on their side yet.
Files.newByteChannel(path); // Fails with ERROR_PIPE_BUSY.
}
```
This revision adds an explicit check if some file looks like a Windows pipe. In these cases `RandomAccessFile` and `FileInputStream` don't call `Files.readAttributes` for the file.
Fixes locked jars when using java.system.class.loader property.
Collaborator
|
vprovodin
force-pushed
the
main
branch
2 times, most recently
from
6cffaf8 to
f6231ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.