Model listeners per project #1510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use interfaces instead of deprecated empty base classes * Replace usage of a deprecated method
Keep global repo listener along with legacy SModelListener for another refactoring round. Quite some TODOs left for further improvements.
Split GlobalListener into two classes: ListenersCollection, a global listener collection that updates as modules are loaded and unloaded and accepts forwarded events, and ForwardingModelListener, a per-project listener that forwards model events to ListenerCache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the part of PR #1439 that was focused on model listeners, a few clean ups to remove deprecated methods, and a refactoring to stop using
MPSModuleRepository.getInstance(). No changes should be user-visible.