Skip to content

Conversation

@alexanderpann
Copy link
Collaborator

No description provided.

@sergej-koscejev
Copy link
Collaborator

sergej-koscejev commented Nov 11, 2025

Does the code actually work for you with NavigationSupport? In other places this caused deadlocks and I had to change it to EditorNavigator. This would also be preferable if you had time to do it (and test it) because EditorNavigator is part of openapi and NavigationSupport isn't.

EDIT: I'm wrong here, both are part of openapi but MPS people (@artem-tikhomirov) mentioned that EditorNavigator is preferred.

@alexanderpann
Copy link
Collaborator Author

I don't get when this listener is executed. I couldn't reproduce the original issue with the freeze on my Mac before.

Copy link
Collaborator

@sergej-koscejev sergej-koscejev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'm going to approve this because this is an improvement, whereas the deadlock is impossible to reproduce and the samples are a pain to work with. However, I see two problems remaining in the code (not directly related to the scope of this PR): the use of NavigationSupport and the fact that the editor extensions is registered via the project but editor extensions became application-level some time in or before 2025.1.

@sergej-koscejev sergej-koscejev merged commit 45c3c7c into maintenance/mps20251 Nov 11, 2025
2 checks passed
@sergej-koscejev sergej-koscejev deleted the bugfix/nullPointerException branch November 11, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants