Feature: Add (more) support for show if blocks, parent styles and style sheet items in Grammar Cells #1664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderpann
requested review from
sergej-koscejev and
wsafonov
as code owners
alexanderpann
force-pushed
the
feature/grammarcells_more_supported_standard_options
branch
from
ae52a38 to
af633c2
Compare
alexanderpann
force-pushed
the
feature/grammarcells_more_supported_standard_options
branch
from
af633c2 to
226a14d
Compare
alexanderpann
force-pushed
the
feature/grammarcells_more_supported_standard_options
branch
from
226a14d to
5f534e6
Compare
alexanderpann
requested review from
AtanasM98
and removed request for
sergej-koscejev and
wsafonov
AtanasM98
approved these changes
Nov 26, 2025
sergej-koscejev
approved these changes
Nov 27, 2025
Collaborator
sergej-koscejev
left a comment
sergej-koscejev
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for implementing this.
alexanderpann
deleted the
feature/grammarcells_more_supported_standard_options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only exception for if blocks are optional cells where I couldn't implement the necessary logic. Please check closely. Those changes could be very breaking. What has to be checked is that we don't generate any unnecessary new cells that might break existing code.