Move the experimental alias customization feature into a separate plugin + remove builder parameter #1692
+2,820
−2,317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderpann
requested review from
sergej-koscejev and
wsafonov
as code owners
alexanderpann
force-pushed
the
bugfix/concept_alias_customization_separate_lanaguage
branch
4 times, most recently
from
83dd794 to
8fcb420
Compare
sergej-koscejev
approved these changes
Dec 5, 2025
Collaborator
sergej-koscejev
left a comment
sergej-koscejev
left a comment
There was a problem hiding this comment.
I think the API should be simpler: pass a map<string, string> to the extension objects in some priority order, and expect them to fill it in (a later extension may remove or modify the entries added by earlier extensions).
The plugin should be application-level, not project-level.
The repository parameter is problematic in my view (we are accessing nodes while redefining concepts, potentially for these same nodes?) but may be okay.
I'm approving the PR despite my reservations because the move to a separate language is important. Since the functionality is experimental anyway, breaking changes in the future are acceptable.
alexanderpann
force-pushed
the
bugfix/concept_alias_customization_separate_lanaguage
branch
from
8fcb420 to
7847b2c
Compare
Collaborator
Author
|
@sergej-koscejev I addressed the review comments. Yes, this API looks better. |
alexanderpann
force-pushed
the
bugfix/concept_alias_customization_separate_lanaguage
branch
from
7847b2c to
84df946
Compare
…age nl.f1re.mps.aliascustomization + refactor implementation
alexanderpann
force-pushed
the
bugfix/concept_alias_customization_separate_lanaguage
branch
from
84df946 to
6633047
Compare
sergej-koscejev
approved these changes
Dec 9, 2025
alexanderpann
deleted the
bugfix/concept_alias_customization_separate_lanaguage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin is called
nl.f1re.mps.aliascustomization. Please be aware that this feature is experimental. Use it with care!