Draft
Conversation
9fadcf6 to
d7b0d62
Compare
d7b0d62 to
c857643
Compare
… into `SymbolicName`
Renamed ScopedKotlinNameBuilder to ScopedNameBuilder
01d2050 to
ff4795c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should not be merged before #101
This PR refactors some part of the name hierarchy. This are the changes and the consequences:
Change:
SpecialNamewas split intoDomainAssociatedFuncNameandSpecialFieldName.Consequence:
df(domain-function) instead ofsp(special)p(property) instead ofspChange:
PredicateKotlinNamewas renamed toPredicateNameand does no longer inheritKotlinNamebutFreshName. The same was done forHavocKotlinName.Consequence:
The
ScopedKotlinNamedoes now hold aSymbolicNameinstead of aKotlinName. Also it was renamed to justScopedNameChange:
The file
FreshNameswas renamed toFreshNameto be consistent withKotlinNameConsequence:
None
Change:
NamedEntitywas introduced as a top level interface forSymbolicName,FreshName,ScopeName, andNameType. This is also for preparation such that a future name resolver can collect all these things in a single collection.Consequence:
None, all subtype relation which hold previously still hold.
Change:
SetOfNameswas changed toListOfNamesand made generic.Consequence:
None
Change:
Instead of giving function types just a list of names as name we introduce
FunctionTypeNameto give functions an actual nameConsequence:
None