Draft
Conversation
Replace the old field-based `hierarchyPathTo(field: FieldEmbedding)` on `ClassEmbeddingDetails` — which skipped interface supertypes via the `isInterface` flag — with a target-based `hierarchyPathTo(target: ClassTypeEmbedding)` backed by a private `pathToOrNull` that searches all supertypes uniformly. Remove the now-redundant `isInterface` constructor parameter and its passing site in `ProgramConverter`. Move field-to-target resolution into `TypeEmbedding.hierarchyPathTo(field)`. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR was extracted from #92 and concerns the implementation of interface-related permissions. Currently, we mostly apply the same permission handling to classes and interfaces, but limit the operations that can be performed with interfaces in certain locations, e.g. when traversing subtyping hierarchies. To implement a proper inheritance system, a separate permissions system for interfaces should be developed.
This PR contains some work in this regard, but lacks the fundamental theoretical backbone. Hopefully, it can be reused when a proper system for interface permissions was agreed on.
Changes
isInterface: Booleanfield fromClassEmbeddingDetailsand replaces the field-basedhierarchyPathTo(field)with a target-basedhierarchyPathTo(target)backed by a privatepathToOrNullthat searches all class supertypes, including interfaces.TypeEmbedding.hierarchyPathTo(field).Remaining tasks