Skip to content

Support casts in uniqueness checker#82

Open
paganma wants to merge 18 commits intomainfrom
marco/support-casts-in-uniqueness-checker
Open

Support casts in uniqueness checker#82
paganma wants to merge 18 commits intomainfrom
marco/support-casts-in-uniqueness-checker

Conversation

@paganma
Copy link
Copy Markdown
Collaborator

@paganma paganma commented Mar 20, 2026

This PR adds support for extracting paths from cast and smartcast expressions.
In addition to this, it also adds the following fixes:

  • Refactor the logic for resolving function declarations from UniquenessGraphAnalyzer and UniquenessGraphChecker.
  • Fixes a bug where the whole flow UniquenessTrie was checked for invariance as opposed to just the subtree of the leaked variable.

@paganma paganma linked an issue Mar 20, 2026 that may be closed by this pull request
@paganma paganma requested a review from jesyspa March 20, 2026 15:19
@paganma paganma marked this pull request as draft March 20, 2026 15:29
@paganma paganma self-assigned this Mar 20, 2026
@paganma paganma force-pushed the marco/support-casts-in-uniqueness-checker branch from 7c1184f to 902c3f5 Compare March 20, 2026 16:24
@paganma paganma marked this pull request as ready for review March 20, 2026 16:25
@jesyspa
Copy link
Copy Markdown
Collaborator

jesyspa commented Mar 21, 2026

I am going to be busy until Wednesday at the earliest, so I think sending this to @ligee for review would make more sense. That said, it looks like you're still making changes to it - please request a review only when you're done.

@paganma paganma requested a review from ligee March 24, 2026 08:05
Copy link
Copy Markdown
Collaborator

@jesyspa jesyspa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool special cases, agreed that this is the intended behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support of Casts In Uniqueness Checker

2 participants