Open
Conversation
… not working but im not quite sure why
…Access not being allowed in PureLinearizer
TheDeveloper101
requested review from
The-Ray-Man and
jesyspa
and removed request for
jesyspa
The-Ray-Man
requested changes
Apr 8, 2026
Collaborator
The-Ray-Man
left a comment
The-Ray-Man
left a comment
There was a problem hiding this comment.
I think that goes into a good direction. Made some remarks about error handling.
...mpiler-plugin/core/src/org/jetbrains/kotlin/formver/core/conversion/StmtConversionContext.kt
Outdated
Show resolved
Hide resolved
...mpiler-plugin/core/src/org/jetbrains/kotlin/formver/core/conversion/StmtConversionVisitor.kt
Outdated
Show resolved
Hide resolved
...mpiler-plugin/core/src/org/jetbrains/kotlin/formver/core/conversion/StmtConversionContext.kt
Show resolved
Hide resolved
…ed implementing default full permission for acc statements
Collaborator
Author
|
I was able to add in the error handling pretty easily. However, when I am trying to add the default value of |
The-Ray-Man
reviewed
Apr 9, 2026
| val read : Permission | ||
| get() = throw FormverFunctionCalledInRuntimeException("read.get") | ||
| val write : Permission | ||
| get() = throw FormverFunctionCalledInRuntimeException("write.get") |
Collaborator
There was a problem hiding this comment.
I did not yet work with the Builtins logic yet, but I do not understand why we have the read and write?
Collaborator
Author
There was a problem hiding this comment.
that was because we wanted to be able to embed the read and write parameters, so we needed to add them to the builtins since they’re not functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the syntax for
accstatements in preconditions, therefore allowing for explicit permissions management as mentioned in #34.