Skip to content

TW-103211 Commit Status Publisher: stored XSS from build configuratio… #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IlyaFomenko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TW-103211 Commit Status Publisher: stored XSS from build configuratio… #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 21 additions & 18 deletions ...-server/src/main/resources/buildServerResources/bitbucketCloud/bitbucketCloudSettings.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,25 +47,28 @@
Specifies the name of the build displayed in the status message posted to the Bitbucket Cloud
</span>
<script type="text/javascript">
BS.Clipboard('.clipboard-btn', {
text: function(trigger) {
const buildName = document.getElementById('${keys.buildName}').value;
if (!buildName) {
return '${defaultBuildName}';
(() => {
const defaultBuildName = '<bs:escapeForJs text="${defaultBuildName}"/>';
BS.Clipboard('.clipboard-btn', {
text: function(trigger) {
const buildName = document.getElementById('${keys.buildName}').value;
if (!buildName) {
return defaultBuildName;
}
return buildName;
}
return buildName;
}
});


$j(document).ready(function() {
if("${not empty defaultBuildName}" === "true") {
document.getElementById('${keys.buildName}').setAttribute('placeholder', '${defaultBuildName}');
}
if ("${isNew}" && !document.getElementById('${keys.buildName}').value) {
document.getElementById('${keys.buildName}').setAttribute('value', '${defaultBuildName}'.replace(/ #<BUILD_NUMBER>$/, ''));
}
});
});


$j(document).ready(function() {
if("${not empty defaultBuildName}" === "true") {
document.getElementById('${keys.buildName}').setAttribute('placeholder', defaultBuildName);
}
if ("${isNew}" && !document.getElementById('${keys.buildName}').value) {
document.getElementById('${keys.buildName}').setAttribute('value', defaultBuildName.replace(/ #<BUILD_NUMBER>$/, ''));
}
});
})();
</script>
</td>
</tr>
Expand Down
55 changes: 30 additions & 25 deletions ...status-publisher-server/src/main/resources/buildServerResources/github/githubSettings.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,33 +61,38 @@
The <b>Status check name</b> value for GitHub. Specifies the name of the check name displayed in the status message posted to the GitHub.
</span>
<script type="text/javascript">
BS.Clipboard('.clipboard-btn', {
text: function(trigger) {
const buildName = document.getElementById('${keys.statusContext}').value;
if (!buildName) {
return '${defaultBuildName}';
}
return buildName;
}
});

$j(document).ready(function() {
if("${empty outdatedGitHubContext}" === "true") {
if("${not empty defaultBuildName}" === "true") {
document.getElementById('${keys.statusContext}').setAttribute('placeholder', '${defaultBuildName}');
}
if ("${isNew}" && !document.getElementById('${keys.statusContext}').value) {
document.getElementById('${keys.statusContext}').setAttribute('value', '${defaultBuildName}');
}
} else {
document.getElementById('${keys.statusContext}').setAttribute('placeholder', '${outdatedGitHubContext}');
if("${isNew}" && !document.getElementById('${keys.statusContext}').value) {
document.getElementById('${keys.statusContext}').setAttribute('value', '${outdatedGitHubContext}');
(() => {
const defaultBuildName = '<bs:escapeForJs text="${defaultBuildName}"/>';
const outdatedGitHubContext = '<bs:escapeForJs text="${outdatedGitHubContext}"/>';

BS.Clipboard('.clipboard-btn', {
text: function(trigger) {
const buildName = document.getElementById('${keys.statusContext}').value;
if (!buildName) {
return defaultBuildName;
}
return buildName;
}
});

document.getElementById('error_${keys.statusContext}').textContent = 'Warning: This configuration is using the outdated \"teamcity.commitStatusPublisher.githubContext\" parameter. Please remove it and use this build feature property instead.';
}
});
$j(document).ready(function() {
if("${empty outdatedGitHubContext}" === "true") {
if("${not empty defaultBuildName}" === "true") {
document.getElementById('${keys.statusContext}').setAttribute('placeholder', defaultBuildName);
}
if ("${isNew}" && !document.getElementById('${keys.statusContext}').value) {
document.getElementById('${keys.statusContext}').setAttribute('value', defaultBuildName);
}
} else {
document.getElementById('${keys.statusContext}').setAttribute('placeholder', outdatedGitHubContext);
if("${isNew}" && !document.getElementById('${keys.statusContext}').value) {
document.getElementById('${keys.statusContext}').setAttribute('value', outdatedGitHubContext);
}

document.getElementById('error_${keys.statusContext}').textContent = 'Warning: This configuration is using the outdated \"teamcity.commitStatusPublisher.githubContext\" parameter. Please remove it and use this build feature property instead.';
}
});
})();
</script>
</td>
</tr>
Expand Down
35 changes: 19 additions & 16 deletions ...status-publisher-server/src/main/resources/buildServerResources/gitlab/gitlabSettings.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,24 +47,27 @@
The <b>External job name</b> value for GitLab. Specifies the name of the job displayed in the status message posted to the GitLab
</span>
<script type="text/javascript">
BS.Clipboard('.clipboard-btn', {
text: function(trigger) {
const buildName = document.getElementById('${keys.buildName}').value;
if (!buildName) {
return '${defaultBuildName}';
(() => {
const defaultBuildName = '<bs:escapeForJs text="${defaultBuildName}"/>';
BS.Clipboard('.clipboard-btn', {
text: function(trigger) {
const buildName = document.getElementById('${keys.buildName}').value;
if (!buildName) {
return defaultBuildName;
}
return buildName;
}
return buildName;
}
});
});

$j(document).ready(function() {
if("${not empty defaultBuildName}" === "true") {
document.getElementById('${keys.buildName}').setAttribute('placeholder', '${defaultBuildName}');
}
if ("${isNew}" && !document.getElementById('${keys.buildName}').value) {
document.getElementById('${keys.buildName}').setAttribute('value', '${defaultBuildName}');
}
});
$j(document).ready(function() {
if("${not empty defaultBuildName}" === "true") {
document.getElementById('${keys.buildName}').setAttribute('placeholder', defaultBuildName);
}
if ("${isNew}" && !document.getElementById('${keys.buildName}').value) {
document.getElementById('${keys.buildName}').setAttribute('value', defaultBuildName);
}
});
})();
</script>
</td>
</tr>
Expand Down
35 changes: 19 additions & 16 deletions ...t-status-publisher-server/src/main/resources/buildServerResources/stash/stashSettings.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,24 +46,27 @@
Specifies the name of the build displayed in the status message posted to the Bitbucket Data Center
</span>
<script type="text/javascript">
BS.Clipboard('.clipboard-btn', {
text: function(trigger) {
const buildName = document.getElementById('${keys.buildName}').value;
if (!buildName) {
return '${defaultBuildName}';
(() => {
const defaultBuildName = '<bs:escapeForJs text="${defaultBuildName}"/>';
BS.Clipboard('.clipboard-btn', {
text: function(trigger) {
const buildName = document.getElementById('${keys.buildName}').value;
if (!buildName) {
return defaultBuildName;
}
return buildName;
}
return buildName;
}
});
});

$j(document).ready(function() {
if("${not empty defaultBuildName}" === "true") {
document.getElementById('${keys.buildName}').setAttribute('placeholder', '${defaultBuildName}');
}
if ("${isNew}" && !document.getElementById('${keys.buildName}').value) {
document.getElementById('${keys.buildName}').setAttribute('value', '${defaultBuildName}'.replace(/ #<BUILD_NUMBER>$/, ''));
}
});
$j(document).ready(function() {
if("${not empty defaultBuildName}" === "true") {
document.getElementById('${keys.buildName}').setAttribute('placeholder', defaultBuildName);
}
if ("${isNew}" && !document.getElementById('${keys.buildName}').value) {
document.getElementById('${keys.buildName}').setAttribute('value', defaultBuildName.replace(/ #<BUILD_NUMBER>$/, ''));
}
});
})();
</script>
</td>
</tr>
Expand Down
37 changes: 20 additions & 17 deletions commit-status-publisher-server/src/main/resources/buildServerResources/tfs/tfsSettings.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,24 +50,27 @@
Specifies the name of the build displayed in the status message posted to the Azure DevOps
</span>
<script type="text/javascript">
BS.Clipboard('.clipboard-btn', {
text: function(trigger) {
const buildName = document.getElementById('${keys.buildName}').value;
if (!buildName) {
return '${defaultBuildName} <BUILD_NUMBER>';
(() => {
const defaultBuildName = '<bs:escapeForJs text="${defaultBuildName}"/>';
BS.Clipboard('.clipboard-btn', {
text: function(trigger) {
const buildName = document.getElementById('${keys.buildName}').value;
if (!buildName) {
return defaultBuildName + ' <BUILD_NUMBER>';
}
return buildName;
}
return buildName;
}
});

$j(document).ready(function() {
if("${not empty defaultBuildName}" === "true") {
document.getElementById('${keys.buildName}').setAttribute('placeholder', '${defaultBuildName} <BUILD_NUMBER>');
}
if ("${isNew}" && !document.getElementById('${keys.buildName}').value) {
document.getElementById('${keys.buildName}').setAttribute('value', '${defaultBuildName}');
}
});
});

$j(document).ready(function() {
if("${not empty defaultBuildName}" === "true") {
document.getElementById('${keys.buildName}').setAttribute('placeholder', defaultBuildName + ' <BUILD_NUMBER>');
}
if ("${isNew}" && !document.getElementById('${keys.buildName}').value) {
document.getElementById('${keys.buildName}').setAttribute('value', defaultBuildName);
}
});
})();
</script>
</td>
</tr>
Expand Down