GraphicsLayer implementation based on adopted RenderNode
#1784
+488
−525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 38ad3c2.
Closed
igordmn
approved these changes
Jan 29, 2025
...ose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/GraphicsLayerOwnerLayer.skiko.kt
Show resolved
Hide resolved
# Conflicts: # compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/node/RootNodeOwner.skiko.kt
igordmn
approved these changes
Jan 30, 2025
MatkovIvan
added a commit
that referenced
this pull request
Jan 31, 2025
Fixes https://youtrack.jetbrains.com/issue/CMP-7508 Skiko change: JetBrains/skiko#1018 Regression after #1784 ## Testing Covered by integration tests ## Release Notes N/A
MatkovIvan
added a commit
that referenced
this pull request
Feb 12, 2025
The fix itself was in #1784, here it's just an addition test Fixes [CMP-7573](https://youtrack.jetbrains.com/issue/CMP-7573) ## Release Notes N/A
MatkovIvan
added a commit
that referenced
this pull request
Feb 14, 2025
After #1784 the stacktrace is different, but the root reason is still here Fixes [CMP-7608](https://youtrack.jetbrains.com/issue/CMP-7608) kotlin.IllegalArgumentException: Object already closed: Picture ## Testing Reproduction is not clear ## Release Notes ### Fixes - Multiple Platforms - Fix possible `IllegalArgumentException: Object already closed` during `GraphicsLayer.record`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skiko side change: JetBrains/skiko#1014
Fixes: CMP-5924, CMP-6703 and problems mentioned in #1777. Removes internal states from draw phase
Testing
Existing tests, manually
TBD: Add something about performance improvements in release notes once we have some specific numbers from our benchmarks
Release Notes
Fixes - Multiple Platforms
placeWithLayerscale application: offset is not scaled now (Android behavior)