Expose SkiaLayerComponent.sceneRoot and simplify AccessibleFocusHelper creation #2714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sasha
commented
Jan 22, 2026
...se/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/skia/SkiaLayerComponent.desktop.kt
Outdated
Show resolved
Hide resolved
igordmn
reviewed
Jan 22, 2026
...se/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/skia/SkiaLayerComponent.desktop.kt
Outdated
Show resolved
Hide resolved
...se/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/skia/SkiaLayerComponent.desktop.kt
Outdated
Show resolved
Hide resolved
igordmn
reviewed
Jan 22, 2026
| @@ -140,7 +140,7 @@ internal class ComposeSceneMediator( | |||
| var rootForTestListener: PlatformContext.RootForTestListener? by DelegateRootForTestListener() | |||
Collaborator
There was a problem hiding this comment.
As a consequence of this discussion.
The Mediator code and its connections is complicated, maybe it is worth to refactor it in the future. Current issues:
- it is difficult to define the data flow just looking at the mediator - we have a lot of public properties/methods, and they can be accessed by the owners and the children
- we have 1000 lines of code, worth to extract some code
- Personally, to easy understand the structure, I would not use a mediator pattern, but just something hierarchical that is a part of a parent (window, layer) and has some children (scene, component)
m-sasha
force-pushed
the
m-sasha/expose-SkiaLayerComponent-sceneRoot
branch
from
53702d1 to
ab0332a
Compare
igordmn
reviewed
Jan 22, 2026
...se/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/skia/SkiaLayerComponent.desktop.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.desktop.kt
Show resolved
Hide resolved
...ose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/a11y/ComposeSceneAccessible.kt
Show resolved
Hide resolved
igordmn
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose SkiaLayerComponent.sceneRoot and simplify AccessibleFocusHelper creation
This is just a refactoring.
Testing
N/A
Release Notes
N/A