Check if setting the same size does not invalidate things#2757
Merged
MatkovIvan merged 3 commits intojb-mainfrom Feb 12, 2026
Merged
Check if setting the same size does not invalidate things#2757MatkovIvan merged 3 commits intojb-mainfrom
MatkovIvan merged 3 commits intojb-mainfrom
Conversation
m-sasha
approved these changes
Feb 12, 2026
Comment on lines
+162
to
+191
| var measureAndLayoutCount = 0 | ||
|
|
||
| val owner = RootNodeOwner( | ||
| snapshotInvalidationTracker = SnapshotInvalidationTracker { | ||
| measureAndLayoutCount++ | ||
| } | ||
| ) | ||
|
|
||
| // Set initial size | ||
| owner.size = IntSize(100, 100) | ||
| val initialCount = measureAndLayoutCount | ||
|
|
||
| // Setting the same size should not trigger measure and layout | ||
| owner.size = IntSize(100, 100) | ||
|
|
||
| // Count should remain the same | ||
| assertEquals(measureAndLayoutCount, initialCount) | ||
|
|
||
| // Setting a different size should trigger measure and layout | ||
| owner.size = IntSize(200, 200) | ||
|
|
||
| // Count should increase | ||
| assertTrue(measureAndLayoutCount > initialCount) | ||
| val afterChangeCount = measureAndLayoutCount | ||
|
|
||
| // Setting the same size again should not trigger another measure and layout | ||
| owner.size = IntSize(200, 200) | ||
|
|
||
| // Count should remain the same | ||
| assertEquals(measureAndLayoutCount, afterChangeCount) |
There was a problem hiding this comment.
The wording here is a bit confusing, because there's no measure-and-layout happening.
I'd suggest:
- Rename
measureAndLayoutCounttoinvalidationCount. - Change the comments from "trigger measure and layout" to "triggerInvalidation".
igordmn
approved these changes
Feb 12, 2026
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/node/RootNodeOwner.skiko.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issue that was found during the investigation of CMP-4556
Release Notes
N/A