Skip to content

Clarify hasInvalidations #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-sasha merged 1 commit into from
Feb 12, 2026
Merged

Clarify hasInvalidations #2758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/ImageComposeScene.skiko.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,16 @@ class ImageComposeScene @ExperimentalComposeUiApi constructor(
set(value) { scene.size = value.toIntSize() }

/**
* Returns true if there are pending recompositions, renders or dispatched tasks.
* Returns whether there are pending recompositions, renders, or dispatched tasks.
* Can be called from any thread.
*
* Note that changes to snapshot state don't immediately trigger an invalidation.
* To guarantee that there are no changes expected in the scene use
* ```
* !Snapshot.current.hasPendingChanges()
* && !Snapshot.isApplyObserverNotificationPending
* && !scene.hasInvalidations()
* ```
*/
fun hasInvalidations() = scene.hasInvalidations()

Expand Down
10 changes: 9 additions & 1 deletion compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/ComposeScene.skiko.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,16 @@ sealed interface ComposeScene : AutoCloseable {
fun invalidatePositionOnScreen()

/**
* Returns true if there are pending recompositions, renders or dispatched tasks.
* Returns whether there are pending recompositions, renders, or dispatched tasks.
* Can be called from any thread.
*
* Note that changes to snapshot state don't immediately trigger an invalidation.
* To guarantee that there are no changes expected in the scene use
* ```
* !Snapshot.current.hasPendingChanges()
* && !Snapshot.isApplyObserverNotificationPending
* && !scene.hasInvalidations()
* ```
*/
fun hasInvalidations(): Boolean

Expand Down