Migrate Modifier.magnifier from Modifier.composed to Modifier.Node#2858
Open
Migrate Modifier.magnifier from Modifier.composed to Modifier.Node#2858
Conversation
ASalavei
requested changes
Mar 12, 2026
ASalavei
left a comment
ASalavei
left a comment
There was a problem hiding this comment.
LGTM. Could you please add a test that magnifier appears on long press (for BTF and BTF2 with NITI off), drags to the new location and disappears on release?
mazunin-v-jb
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate Modifier.magnifier from Modifier.composed to Modifier.Node
Fixes CMP-9914
Release Notes
N/A