Benchmarks. Support GPU on Windows#5216
Conversation
| @@ -1,4 +1,4 @@ | |||
| compose.version=1.7.1 | |||
There was a problem hiding this comment.
We shouldn't merge until we build compose with JetBrains/skiko#1016.
The PR only works with custom Skiko right now:
// in skiko
checkout igor.demin/DirectXOffscreenContext
./gradlew publishToMavenLocal -deploy.version=722.0.0
// in benchmarks in build.gradle
val desktopMain by getting {
dependencies {
...
implementation("org.jetbrains.skiko:skiko:722.0.0-SNAPSHOT")
implementation("org.jetbrains.skiko:skiko-awt-runtime-macos-arm64:722.0.0-SNAPSHOT")
There was a problem hiding this comment.
Changed.
Though, after migrating to new Compose, we can't no longer test pre 1.8.0+dev2047 version without manually commenting the not-compiling DirectXOffscreenContext/DirectXOffscreenContext.
Is it fine, or should we wait merging?
There was a problem hiding this comment.
Maybe it is better to make the dependency reflective for now?
However this way, we cannot compare with the old version anyway. I would add an option to choose between null/GPU/software rendering in addition, with backward compatible defaults.
I would probably also wait GPU renderers for non-Windows desktop targets to have common code here.
There was a problem hiding this comment.
I would add an option
Because we need to include/exclude compilation of new classes, we have to use a Gradle property to include/exclude additional sourceset/module. It works, but complicates the build and structure. A simpler solution is to wait merging.
What, if we wait for 1.8.0 Stable? We always could back in time, and checkout v1.8.0 tag for old versions testing.
I would probably also wait GPU renderers for non-Windows desktop targets to have common code here.
Let's discuss again at the 1.8.0’s release. I would prefer merging it even if only Windows supported at that moment, as it seems merging only it doesn't have downsides?
5052874 to
9815867
Compare
a6c379d to
f600ab2
Compare
|
Nikita Lipsky (@pjBooms), can we merge it now? |
5d987d1 to
dae4d7c
Compare
Partially fixes https://youtrack.jetbrains.com/issue/CMP-7475/Benchmarks.-Add-ability-to-test-GPU-on-desktop-JVM (for Windows) ## Release notes N/A
Partially fixes https://youtrack.jetbrains.com/issue/CMP-7475/Benchmarks.-Add-ability-to-test-GPU-on-desktop-JVM (for Windows)
Release notes
N/A