rework compose compiler tests for k2#5325
Merged
Pavel Shishkin (shishkin-pavel) merged 5 commits intoMay 27, 2025
Merged
Conversation
Pavel Shishkin (shishkin-pavel)
requested review from
Oleksandr Karpovich (eymar) and
Igor Demin (igordmn)
Igor Demin (igordmn)
approved these changes
May 26, 2025
| register("libs").configure { | ||
| val kotlinVersion = providers.gradleProperty("kotlin_version").orNull | ||
| // if (kotlinVersion != null) { | ||
| // version("kotlin", kotlinVersion) |
Member
There was a problem hiding this comment.
Don't we want to have this? So CI can override the kotlin version?
in libs versions catalogue I see a comment:
kotlin="2.1.21" # should be provided via `-Pkotlin_version=<kotlin version to test with>`
Contributor
Author
There was a problem hiding this comment.
haven't noticed comments were too broad, thanks, fixed
Member
|
Could you please update README.MD so it has updated instructions about how to run the tests? Now it mentions |
Oleksandr Karpovich (eymar)
approved these changes
May 27, 2025
Pavel Shishkin (shishkin-pavel)
deleted the
shish/compose-compiler-tests-k2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
migrate compose compiler tests to work with k2
Testing
N/A
Release Notes
N/A