Increase load on the CanvasDrawing test#5624
Open
Andrei Salavei (ASalavei) wants to merge 3 commits into
Open
Conversation
Nikita Lipsky (pjBooms)
requested changes
Jun 22, 2026
| ) | ||
|
|
||
| repeat(200) { i -> | ||
| repeat(300) { i -> |
Contributor
There was a problem hiding this comment.
We already have a history for CanvasDrawing on the benchmark server. So I would suggest to introduce parameters for the benchmark and register two benchmarks: with old values and new ones (say CanvasDrawingHeavy). See also similar thing for LazyGrid or MultipleComponents.
Contributor
Author
There was a problem hiding this comment.
Done. I checked a solution how to tweak params to increase complexity, but at the end - we have to tweak too much, so I added a new list cell here.
|
|
||
| @Composable | ||
| private fun CanvasDrawingItem(index: Int) { | ||
| private fun EasyCanvasDrawingItem(index: Int) { |
Contributor
There was a problem hiding this comment.
Easy and Medium Items have many things in common. I would de-duplicate them.
Nikita Lipsky (pjBooms)
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CanvasDrawing became too easy for 60 FPS devices and became less useful.
The MR increase number of draw calls during this tests to provide more versatile data.
Also, enable Always On screen on iOS to eliminate screen deeming issues during the tests.
Release Notes
N/A