Added script to measure latency #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosstbarz
commented
Jan 22, 2026
| visualization_prompt = state.get("visualization_prompt") | ||
| result = ExecutionResult( | ||
| text=last_ai_message.text(), | ||
| text=last_ai_message.text, |
Contributor
Author
There was a problem hiding this comment.
New version of LangChain raise deprecation warning on this.
catstrike
requested changes
Jan 25, 2026
examples/latency.py
Outdated
|
|
||
|
|
||
| def run_scenario() -> bool: | ||
| DB_PATH = file_path / "web_shop_orders/data/web_shop.duckdb" |
Collaborator
There was a problem hiding this comment.
DB_PATH isn’t a global constant here, so it would be better to use lowercase to match the naming conventions.
examples/latency.py
Outdated
Comment on lines
51
to
53
| print( | ||
| f"Mean time: {sum(time_measures) / len(time_measures):.2f} seconds, Std: {pd.Series(time_measures).std():.2f}" | ||
| ) |
Collaborator
There was a problem hiding this comment.
To make this a bit cleaner, I’d suggest rewriting it as:
measures = pd.Series(time_measures)
print(
f"Mean time: {measures.mean():.2f} seconds, Std: {measures.std():.2f}"
)
catstrike
approved these changes
Jan 26, 2026
Collaborator
catstrike
left a comment
catstrike
left a comment
There was a problem hiding this comment.
Please squash commits before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.