-
Notifications
You must be signed in to change notification settings - Fork 2
Schema inspection from Lighthouse (all in one) #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apply necessary ruff and mypy changes.
# Conflicts: # portus/__init__.py # pyproject.toml # uv.lock
Not hooked up to agents yet.
Remove query caching
This reverts commit 8d4ea32
|
There is potentially a lot we could simplify, like removing |
|
This is what the inspected schema looks like for demo.py: *NEW example in #45 |
|
Based on the example I can suggest make schema as small as possible until performance drops. |
* Make column_value_stats_summary.jinja more readable * Shorten column_value_stats_summary.jinja text descriptions * Fix missing DatabaseSchema.description * Simplify "Single constant" output
# Conflicts: # examples/ecom-customers.ipynb # portus/core/session.py
# Conflicts: # portus/core/pipe.py
Fixes failing tests.
We discussed that we will not forcefully maintain compatibility with Lighthouse and we would rather have diverging code bases. Therefore, I will simplify and remove unnecessary baggage left over from the Lighthouse repo. |
|
@mare5x @kosstbarz I took another critical look at the PR and reflected n our conversation. I think we came to a point where we're confident to diverge from the Lighthouse codebase and have less features to reduce the repo entropy. Given that let's drop most of this PR and only keep the disc cache part. Everything else is not relevant for our user in the forceable future. |
Rauf-Kurbanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets only keep disk mini-PR cache and drop everything else
Adapted the schema inspection from Lighthouse to portus. Closes #23.
The PR is huge mostly due to copying a lot of files from Lighthouse.
You can review either this master PR or start with smaller ones (but later PRs make modifications to earlier ones):
DataEngine Adapt DataEngine from Lighthouse #40DataEngineand DataSource Sync and async API for DataEngine and DataSource #36TODO: