Add additional context #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosstbarz
reviewed
Nov 7, 2025
kosstbarz
reviewed
Nov 7, 2025
|
|
||
| context = "" | ||
| for db_name, db_context in db_contexts.items(): | ||
| for db_name, db_context in session.db_context.items(): |
Collaborator
There was a problem hiding this comment.
Why not session.db.context? Is it safe to assume every connector will have a .context field?
Contributor
Author
There was a problem hiding this comment.
Yep, we should add more structure to how we store added databases and dataframes in Session. Currently, it's all dicts so there is no .context field.
| for df_name, df_context in df_contexts.items(): | ||
| for df_name, df_context in session.df_context.items(): | ||
| context += f"## Context for DF {df_name} (fully qualified name 'temp.main.{df_name}')\n\n{df_context}\n\n" | ||
| for idx, additional_ctx in enumerate(session.additional_context, start=1): |
Collaborator
There was a problem hiding this comment.
How long could session.additional_context sequence pontentially be?
Contributor
Author
There was a problem hiding this comment.
Currently there is no limit. In practice, the maximum context size of the LLM is the limit.
Rauf-Kurbanov
approved these changes
Nov 10, 2025
Collaborator
Rauf-Kurbanov
left a comment
Rauf-Kurbanov
left a comment
There was a problem hiding this comment.
All cool, just minor comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59 with a new method: