Demo revamp. Add EDA notebook #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s work (squashed) Backup branch: backup/dmzolotarev-demo-notebooks-eda-20251111-1846
dmzolotarev
force-pushed
the
dmzolotarev/demo-notebooks-eda
branch
from
db73113 to
03867fc
Compare
Contributor
|
I've added |
mare5x
approved these changes
Nov 14, 2025
Contributor
There was a problem hiding this comment.
nit: I would prefer for us to commit only notebooks without any outputs (in PyCharm click the "Clear All Outputs" button) like we have with demo.ipynb and ecom-customers.ipynb. That way the file size is smaller and we are not left with old outputs in the notebook that can change in later versions of databao.
Contributor
Author
There was a problem hiding this comment.
We can discuss it - I'd say for getting started notebooks it's quite important to be able to show how it works without even running it
Contributor
|
I can't see |
mare5x
reviewed
Nov 17, 2025
examples/web_shop_orders/web_shop_orders_databao_reporting_demo.ipynb
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: