Skip to content

Fix validation errors for layered vega-lite charts #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mare5x merged 1 commit into from
Nov 14, 2025
Merged

Fix validation errors for layered vega-lite charts #91

mare5x merged 1 commit into from
Nov 14, 2025

Conversation

@mare5x
Copy link
Contributor

@mare5x mare5x commented Nov 11, 2025

  • Pydantic returned a ValidationError for layered Vega-Lite charts because they are not a subclass of altair.Chart.
  • Added unit tests (with Junie).

@mare5x mare5x requested a review from kosstbarz November 11, 2025 10:46
@mare5x mare5x merged commit eebfe2b into main Nov 14, 2025
2 checks passed
@mare5x mare5x deleted the mhostnik/fix-vegachat-plot-type branch November 14, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kosstbarz kosstbarz kosstbarz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mare5x @kosstbarz