Fix StackOverflowError during "Apply changes to the internal targets model" #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evis
commented
Nov 17, 2025
| // Don't create dependency to synthetic output_jars library if real target already exists | ||
| // This prevents cyclic dependencies like proto -> proto_output_jars -> proto -> proto_output_jars | ||
| if (outputJarsLabel in targetsToImportSet) { | ||
| null |
Author
There was a problem hiding this comment.
This line completely prevents creating the synthetic dependency proto -> proto_output_jars when a real proto_output_jars target exists. While this fixes the StackOverflowError, it causes IDE issues - proto imports now show as unresolved because they can't see the generated Java classes.
The dilemma is:
- With dependency:
proto -> proto_output_jars+proto_output_jars -> proto= cycle → StackOverflowError incalculateTransitivelyExecutableTargets - Without dependency: No cycle, but IDE loses the connection between proto files and generated Java classes
What would be the best approach here to fix it?
- Create the dependency but mark it as "non-transitive" for executable target calculation?
- Fix
calculateTransitivelyExecutableTargetsto handle cycles with recursion protection? - Something else?
Member
|
I wonder if we could just rename the suffix so that a clash is less likely, e.g., _ij_output_jars? |
…model"
Problem: `calculateOutputJarsLibraries()` was creating synthetic dependencies from targets
to output_jars libraries that already exist as real targets. For example, with BUILD file:
```starlark
proto_library(
name = "proto",
srcs = glob(["proto/**/*.proto"]),
strip_import_prefix = "proto",
)
java_proto_library(
name = "proto_output_jars",
deps = [":proto"],
)
```
The plugin would create a synthetic dependency proto -> proto_output_jars,
combined with the real dependency proto_output_jars -> proto, creating cycles:
proto -> proto_output_jars -> proto -> proto_output_jars -> ...
This resulted in infinite recursion and `StackOverflowError` in `calculateTransitivelyExecutableTargets`
during the "Apply changes to the internal targets model" sync phase, causing sync to hang.
Stack trace excerpt:
```
at org.jetbrains.bazel.target.TargetUtils.calculateTransitivelyExecutableTargets(TargetUtils.kt:206)
at org.jetbrains.bazel.target.TargetUtils.access$calculateTransitivelyExecutableTargets(TargetUtils.kt:60)
at org.jetbrains.bazel.target.TargetUtils$calculateTransitivelyExecutableTargets$1$1.invoke(TargetUtils.kt:216)
at org.jetbrains.bazel.target.TargetUtils$calculateTransitivelyExecutableTargets$1$1.invoke(TargetUtils.kt:215)
[infinite recursion continues...]
```
Solution: rename the suffix so that a clash is less likely
evis
force-pushed
the
fix-proto-cycle
branch
from
085813c to
b05eb1c
Compare
Author
Done. Thanks for suggestion! |
Member
|
YT issue to track: BAZEL-2812 StackOverflowError during "Apply changes to the internal targets model" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
calculateOutputJarsLibraries()was creating synthetic dependencies from targets to output_jars libraries that already exist as real targets. For example, with BUILD file:The plugin would create a synthetic dependency proto -> proto_output_jars, combined with the real dependency proto_output_jars -> proto, creating cycles: proto -> proto_output_jars -> proto -> proto_output_jars -> ...
This resulted in infinite recursion and
StackOverflowErrorincalculateTransitivelyExecutableTargetsduring the "Apply changes to the internal targets model" sync phase, causing sync to hang.Stack trace excerpt:
Solution: Don't create dependency from target to synthetic output_jars library if real target already exists.