Fix transitive proto_library dependencies for scala_proto_library #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue where imports from transitive proto_library dependencies were not resolved in IntelliJ. The plugin now correctly adds scalapb JAR files from transitive proto_library dependencies to the module classpath, enabling proper import resolution for scala_proto_library targets with nested proto dependencies. Fixes [BAZEL-2695](https://youtrack.jetbrains.com/issue/BAZEL-2695)
evis
commented
Dec 1, 2025
| val interfacesAndBinariesFromTargetsToImport = | ||
| measure("Collect interfaces and classes from targets to import") { | ||
| collectInterfacesAndClasses(targetsToImport) | ||
| collectInterfacesAndClasses(targetsToImport, allTargets) |
Author
There was a problem hiding this comment.
Is it OK to pass allTargets through several method calls like this?
| val bazelBinPath = | ||
| bazelPathsResolver | ||
| .workspaceRoot() | ||
| .resolve("bazel-bin") |
Author
There was a problem hiding this comment.
Should I rely on the bazel-bin symlink here? I noticed that other JAR files are resolved using direct paths.
Should I use a consistent approach? How would you recommend doing it?
| * Excludes direct scala_proto_library dependencies to avoid duplicating JARs that are already | ||
| * included by the plugin's standard processing. | ||
| */ | ||
| private fun findTransitiveProtoLibraries(target: TargetInfo, allTargets: Map<Label, TargetInfo>): Set<TargetInfo> { |
Author
There was a problem hiding this comment.
Does extracting the transitive proto_library dependency graph for each scala_proto_library target seem reasonable? Or would you prefer a different approach to fix the original problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue where imports from transitive proto_library dependencies were not resolved in IntelliJ.
The plugin now correctly adds scalapb JAR files from transitive proto_library dependencies to the module classpath, enabling proper import resolution for scala_proto_library targets with nested proto dependencies.
Fixes BAZEL-2695
Impact
With this PR, this transitive proto import is now resolved correctly and no longer shows as red in IntelliJ.
Scale of the problem:
This is a significant developer experience improvement for our team. In our Scala code, it's very common to use classes from transitive proto_library dependencies, and currently all such imports show as unresolved.
This has been a persistent pain point for developers working with Scala and protobuf, as it makes code navigation much more difficult when imports appear broken even though they compile correctly with Bazel.