Maintenance: VimExtensionRegistrar - Fix extension statistics tracking #1532
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When extensions were disabled via 'set noExtensionName' or when the extension was unregistered as an extension point, they were properly disposed but not removed from PluginState.Util.enabledExtensions. This caused the statistics to incorrectly show extensions as enabled even after they were disabled. This fix ensures that when an extension is disabled or unregistered, it is also removed from the enabled extensions set used for statistics collection. Changes: - Add PluginState.Util.enabledExtensions.remove(name) in the option change listener when an extension is disabled - Add PluginState.Util.enabledExtensions.remove(name) in unregisterExtension() when an extension is unregistered Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
src/main/java/com/maddyhome/idea/vim/statistic/PluginState.ktand related extension tracking codeVimExtensionRegistrar.ktIssues Found
When extensions were disabled via
set noExtensionNameor when the extension was unregistered as an extension point, they were properly disposed but not removed fromPluginState.Util.enabledExtensions. This caused the statistics to incorrectly show extensions as enabled even after they were disabled.Changes Made
Added
PluginState.Util.enabledExtensions.remove(name)in two locations inVimExtensionRegistrar.kt:unregisterExtension()when an extension is unregistered (line 113)Why This Improves the Code
Related Code
The fix maintains consistency with the existing pattern where extensions are added to the statistics set when enabled (line 70), and now properly removes them when disabled.
🤖 Generated with Claude Code