VIM-4120 Display vim error messages in output panel #1534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1grzyb1
force-pushed
the
VIM-4120/error_message
branch
2 times, most recently
from
b24accf to
b4c3271
Compare
1grzyb1
force-pushed
the
VIM-4120/error_message
branch
from
b4c3271 to
d229a54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces displaying vim error messages in output panel
To achive that I refactor
OutputPanelarchitecture to support showing multiple lines in different styles so we can display errors in red alongside normal output messages.I removed
ExOutputModelwithExOutputPaneland replaced it with a singleOutputPanel. This way, it's much simpler to understand what is going on. Also, there were a lot of strange ifs to unit testisUnitTestModewhich were unnecessary actually and just making it more difficult to read.Screen.Recording.2026-01-28.at.12.47.29.mov