Fix flaky inline rename test #1542
Open
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
According to the status, the flakiness is not fixed :D |
Collaborator
Author
|
Fix flaky inline rename test
1grzyb1
force-pushed
the
grzybek/inline-flaky-test
branch
from
ea68dfa to
3d0c8b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pressing Escape during an active template (e.g., inline rename), a race condition with VimVisualTimer could override the user's intent by switching back to INSERT mode, because the delayed selection change handler assumed being in NORMAL mode with an active template meant the user wanted INSERT.
Solution: Cancel any pending VimVisualTimer callbacks when explicitly exiting INSERT or SELECT mode, ensuring the user's Escape action is respected.