KTL-4245: Explore insights meta#292
Merged
Nikita Vlaev (nikitavlaevjb) merged 24 commits intoMay 29, 2026
Merged
Conversation
Nikita Vlaev (nikitavlaevjb)
requested a review
from Dmitrii Krasnov (dkrasnoff)
Nikita Vlaev (nikitavlaevjb)
force-pushed
the
feature/KTL-4245-Explore-insights-meta
branch
from
df94916 to
e875442
Compare
Dmitrii Krasnov (dkrasnoff)
force-pushed
the
feature/KTL-4245-Explore-insights-meta
branch
3 times, most recently
from
1700252 to
384b931
Compare
Updated the package's dependency counting with this new database hierarchy.
Dmitrii Krasnov (dkrasnoff)
force-pushed
the
feature/KTL-4245-Explore-insights-meta
branch
from
384b931 to
e4ea1e5
Compare
Dmitrii Krasnov (dkrasnoff)
approved these changes
May 22, 2026
| ) | ||
| ) | ||
| } catch (_: DataIntegrityViolationException) { | ||
| // A concurrent transaction inserted the same GAV first — re-read it. |
Collaborator
Author
There was a problem hiding this comment.
Do I understand correctly that there is no test for it?
Is it possible to create one?
Collaborator
Author
There was a problem hiding this comment.
Also not sure that after exception it wouldn't just be a rollback
Collaborator
There was a problem hiding this comment.
Good questions, I'll check.
I thought that DataIntegrityViolationException is not a RuntimeException, and as I recall only RuntimeException raises the rollback
Collaborator
There was a problem hiding this comment.
You were right about the transaction and rollback, I've replaced it with ON CONFLICT DO NOTHING
Dmitrii Krasnov (dkrasnoff)
force-pushed
the
feature/KTL-4245-Explore-insights-meta
branch
from
117a631 to
d7dcf52
Compare
…he redirector returns 404 for content fetches.
…d stats endpoints.
…oop and drop the now-dead queue scheduling column.
…s, insights page).
Moved most of the metrics to okhttp interceptor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meta-issue tracking multiple insights features including KTL-4388 (number of dependents) and KTL-4361 (comparison feature).