-
Notifications
You must be signed in to change notification settings - Fork 310
Fix integration tests #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration tests #1281
Conversation
db487f2 to
271295f
Compare
...rc/jvmTest/kotlin/ai/koog/integration/tests/capabilities/ModelCapabilitiesIntegrationTest.kt
Outdated
Show resolved
Hide resolved
...rc/jvmTest/kotlin/ai/koog/integration/tests/capabilities/ModelCapabilitiesIntegrationTest.kt
Outdated
Show resolved
Hide resolved
...n-tests/src/jvmTest/kotlin/ai/koog/integration/tests/executor/ExecutorIntegrationTestBase.kt
Outdated
Show resolved
Hide resolved
...n-tests/src/jvmTest/kotlin/ai/koog/integration/tests/executor/ExecutorIntegrationTestBase.kt
Outdated
Show resolved
Hide resolved
...oogle-client/src/commonMain/kotlin/ai/koog/prompt/executor/clients/google/GoogleLLMClient.kt
Outdated
Show resolved
Hide resolved
integration-tests/src/jvmTest/kotlin/ai/koog/integration/tests/agent/AIAgentIntegrationTest.kt
Show resolved
Hide resolved
...n-tests/src/jvmTest/kotlin/ai/koog/integration/tests/executor/ExecutorIntegrationTestBase.kt
Outdated
Show resolved
Hide resolved
integration-tests/src/jvmTest/kotlin/ai/koog/integration/tests/utils/Models.kt
Show resolved
Hide resolved
Qodana for JVM1217 new problems were found
@@ Code coverage @@
+ 72% total lines covered
17580 lines analyzed, 12747 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
...n-tests/src/jvmTest/kotlin/ai/koog/integration/tests/executor/ExecutorIntegrationTestBase.kt
Outdated
Show resolved
Hide resolved
...n-tests/src/jvmTest/kotlin/ai/koog/integration/tests/executor/ExecutorIntegrationTestBase.kt
Outdated
Show resolved
Hide resolved
integration-tests/src/jvmTest/kotlin/ai/koog/integration/tests/utils/TestUtils.kt
Outdated
Show resolved
Hide resolved
...oogle-client/src/commonMain/kotlin/ai/koog/prompt/executor/clients/google/GoogleLLMClient.kt
Outdated
Show resolved
Hide resolved
...oogle-client/src/commonMain/kotlin/ai/koog/prompt/executor/clients/google/GoogleLLMClient.kt
Outdated
Show resolved
Hide resolved
kpavlov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just minor comment
agents/agents-core/src/commonMain/kotlin/ai/koog/agents/core/dsl/extension/AIAgentNodes.kt
Outdated
Show resolved
Hide resolved
d4ce2a1 to
f7199b5
Compare
EugeneTheDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your fixes, I have a few minor comments regarding the fixes in the framework
agents/agents-core/src/commonMain/kotlin/ai/koog/agents/core/dsl/extension/AIAgentNodes.kt
Outdated
Show resolved
Hide resolved
agents/agents-core/src/commonMain/kotlin/ai/koog/agents/core/dsl/extension/AIAgentNodes.kt
Outdated
Show resolved
Hide resolved
...oogle-client/src/commonMain/kotlin/ai/koog/prompt/executor/clients/google/GoogleLLMClient.kt
Outdated
Show resolved
Hide resolved
...oogle-client/src/commonMain/kotlin/ai/koog/prompt/executor/clients/google/GoogleLLMClient.kt
Outdated
Show resolved
Hide resolved
...penai-client/src/commonMain/kotlin/ai/koog/prompt/executor/clients/openai/OpenAILLMClient.kt
Show resolved
Hide resolved
...penai-client/src/commonMain/kotlin/ai/koog/prompt/executor/clients/openai/OpenAILLMClient.kt
Outdated
Show resolved
Hide resolved
f6df1bd to
d0374d4
Compare
… test validation.
…st configuration alignments.
…ed response validations, and updated model selection due to stability issues.
…/capabilities/ModelCapabilitiesIntegrationTest.kt Co-authored-by: Sergey Karpov <[email protected]>
…IntegrationTestBase`.
…utorIntegrationTestBase`.
…utorIntegrationTestBase`.
d0374d4 to
13af3ee
Compare
EugeneTheDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thank you
Co-authored-by: Sergey Karpov <[email protected]>
Motivation and Context
Fixing some recent integration tests failures. Also, used AI to fix some of the non-testing code parts, and although I can describe why it's done, a thorough review would be appreciated.
Breaking Changes
Type of the changes
Checklist
developas the base branchAdditional steps for pull requests adding a new feature