Skip to content

Conversation

@aozherelyeva
Copy link
Contributor

Motivation and Context

Fixing some recent integration tests failures. Also, used AI to fix some of the non-testing code parts, and although I can describe why it's done, a thorough review would be appreciated.

Breaking Changes


Type of the changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests improvement
  • Refactoring

Checklist

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

@aozherelyeva aozherelyeva added the tests Add new tests or modify existing label Dec 17, 2025
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Qodana for JVM

1217 new problems were found

Inspection name Severity Problems
Check Kotlin and Java source code coverage 🔶 Warning 1197
Missing KDoc for public API declaration 🔶 Warning 20
@@ Code coverage @@
+ 72% total lines covered
17580 lines analyzed, 12747 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Contributor

@kpavlov kpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comment

@aozherelyeva aozherelyeva force-pushed the fix-tests branch 2 times, most recently from d4ce2a1 to f7199b5 Compare December 17, 2025 11:58
@EugeneTheDev EugeneTheDev self-requested a review December 17, 2025 12:06
Copy link
Collaborator

@EugeneTheDev EugeneTheDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your fixes, I have a few minor comments regarding the fixes in the framework

@aozherelyeva aozherelyeva force-pushed the fix-tests branch 6 times, most recently from f6df1bd to d0374d4 Compare December 17, 2025 17:33
Copy link
Collaborator

@EugeneTheDev EugeneTheDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thank you

@EugeneTheDev EugeneTheDev merged commit 06e8e33 into develop Dec 17, 2025
24 checks passed
@EugeneTheDev EugeneTheDev deleted the fix-tests branch December 17, 2025 23:44
vova-jb pushed a commit that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Add new tests or modify existing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants