Removed requrement for unique node names for Peristency feature #1288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JVM1250 new problems were found
@@ Code coverage @@
+ 71% total lines covered
17885 lines analyzed, 12819 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
EugeneTheDev
previously requested changes
Dec 19, 2025
...s/agents-core/src/commonMain/kotlin/ai/koog/agents/core/agent/entity/AIAgentGraphStrategy.kt
Show resolved
Hide resolved
sdubov
approved these changes
Dec 19, 2025
...gents-features-snapshot/src/commonMain/kotlin/ai/koog/agents/snapshot/feature/Persistence.kt
Outdated
Show resolved
Hide resolved
EugeneTheDev
dismissed
their stale review
Agreed to fix later (please don't forget!), dismissing my review to unblock
Rizzen
force-pushed
the
mark/persistence-node-names02
branch
from
02b38e8 to
505450c
Compare
vova-jb
pushed a commit
that referenced
this pull request
Jan 27, 2026
<!-- Thank you for opening a pull request! Please add a brief description of the proposed change here. Also, please tick the appropriate points in the checklist below. --> ## Motivation and Context Aim of the PR is to remove requirement (and check) for unique graph node names and migrate to node path usage. ## Breaking Changes <!-- Will users need to update their code or configurations? --> Yes --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Tests improvement - [ ] Refactoring #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [ ] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Aim of the PR is to remove requirement (and check) for unique graph node names and migrate to node path usage.
Breaking Changes
Yes
Type of the changes
Checklist
developas the base branchAdditional steps for pull requests adding a new feature