-
Notifications
You must be signed in to change notification settings - Fork 310
feat: Add Awaitility extensions for coroutine support in test-utils #1331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced custom Awaitility extensions to support suspending assertions. - Updated `a2a-test` to use new `test-utils` dependencies for Awaitility utilities. - Upgraded `mockk` and `mockito` dependencies to newer versions.
aozherelyeva
approved these changes
Jan 7, 2026
Contributor
aozherelyeva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Qodana for JVM1263 new problems were found
@@ Code coverage @@
+ 72% total lines covered
18166 lines analyzed, 13169 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
karloti
pushed a commit
to karloti/koog
that referenced
this pull request
Jan 7, 2026
…etBrains#1331) # feat: Add Awaitility extensions for coroutine support in test-utils - Introduced custom Awaitility extensions to support suspending assertions. - Updated `a2a-test` to use new `test-utils` dependencies for Awaitility utilities. - Upgraded `mockk` and `mockito` dependencies to newer versions. ## Motivation and Context [A2AServerJsonRpcIntegrationTest.kt#L74 is flaky](https://github.com/JetBrains/koog/pull/1116/files#annotation_43754744518) It must use awatility to verify eventually consistent conditions ## Breaking Changes No --- #### Type of the changes - [x] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [x] Tests improvement - [ ] Refactoring #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [x] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
vova-jb
pushed a commit
that referenced
this pull request
Jan 27, 2026
…1331) # feat: Add Awaitility extensions for coroutine support in test-utils - Introduced custom Awaitility extensions to support suspending assertions. - Updated `a2a-test` to use new `test-utils` dependencies for Awaitility utilities. - Upgraded `mockk` and `mockito` dependencies to newer versions. ## Motivation and Context [A2AServerJsonRpcIntegrationTest.kt#L74 is flaky](https://github.com/JetBrains/koog/pull/1116/files#annotation_43754744518) It must use awatility to verify eventually consistent conditions ## Breaking Changes No --- #### Type of the changes - [x] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [x] Tests improvement - [ ] Refactoring #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [x] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add Awaitility extensions for coroutine support in test-utils
a2a-testto use newtest-utilsdependencies for Awaitility utilities.mockkandmockitodependencies to newer versions.Motivation and Context
A2AServerJsonRpcIntegrationTest.kt#L74 is flaky
It must use awatility to verify eventually consistent conditions
Breaking Changes
No
Type of the changes
Checklist
developas the base branchAdditional steps for pull requests adding a new feature