Skip to content

Conversation

@kpavlov
Copy link
Contributor

@kpavlov kpavlov commented Jan 7, 2026

feat: Add Awaitility extensions for coroutine support in test-utils

  • Introduced custom Awaitility extensions to support suspending assertions.
  • Updated a2a-test to use new test-utils dependencies for Awaitility utilities.
  • Upgraded mockk and mockito dependencies to newer versions.

Motivation and Context

A2AServerJsonRpcIntegrationTest.kt#L74 is flaky
It must use awatility to verify eventually consistent conditions

Breaking Changes

No


Type of the changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests improvement
  • Refactoring

Checklist

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

- Introduced custom Awaitility extensions to support suspending assertions.
- Updated `a2a-test` to use new `test-utils` dependencies for Awaitility utilities.
- Upgraded `mockk` and `mockito` dependencies to newer versions.
@kpavlov kpavlov added tests Add new tests or modify existing bugfix Something was fixed 🎉 labels Jan 7, 2026
@kpavlov kpavlov marked this pull request as ready for review January 7, 2026 14:12
Copy link
Contributor

@aozherelyeva aozherelyeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Qodana for JVM

1263 new problems were found

Inspection name Severity Problems
Check Kotlin and Java source code coverage 🔶 Warning 1243
Missing KDoc for public API declaration 🔶 Warning 20
@@ Code coverage @@
+ 72% total lines covered
18166 lines analyzed, 13169 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@kpavlov kpavlov merged commit 33c8b43 into develop Jan 7, 2026
18 checks passed
@kpavlov kpavlov deleted the kpavlov/awaitility branch January 7, 2026 14:34
karloti pushed a commit to karloti/koog that referenced this pull request Jan 7, 2026
…etBrains#1331)

# feat: Add Awaitility extensions for coroutine support in test-utils

- Introduced custom Awaitility extensions to support suspending
assertions.
- Updated `a2a-test` to use new `test-utils` dependencies for Awaitility
utilities.
- Upgraded `mockk` and `mockito` dependencies to newer versions.

## Motivation and Context
[A2AServerJsonRpcIntegrationTest.kt#L74 is
flaky](https://github.com/JetBrains/koog/pull/1116/files#annotation_43754744518)
It must use awatility to verify eventually consistent conditions

## Breaking Changes
No

---

#### Type of the changes
- [x] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation update
- [x] Tests improvement
- [ ] Refactoring

#### Checklist
- [x] The pull request has a description of the proposed change
- [x] I read the [Contributing
Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md)
before opening the pull request
- [x] The pull request uses **`develop`** as the base branch
- [x] Tests for the changes have been added
- [x] All new and existing tests passed

##### Additional steps for pull requests adding a new feature
- [ ] An issue describing the proposed change exists
- [ ] The pull request includes a link to the issue
- [ ] The change was discussed and approved in the issue
- [ ] Docs have been added / updated
vova-jb pushed a commit that referenced this pull request Jan 27, 2026
…1331)

# feat: Add Awaitility extensions for coroutine support in test-utils

- Introduced custom Awaitility extensions to support suspending
assertions.
- Updated `a2a-test` to use new `test-utils` dependencies for Awaitility
utilities.
- Upgraded `mockk` and `mockito` dependencies to newer versions.

## Motivation and Context
[A2AServerJsonRpcIntegrationTest.kt#L74 is
flaky](https://github.com/JetBrains/koog/pull/1116/files#annotation_43754744518)
It must use awatility to verify eventually consistent conditions

## Breaking Changes
No

---

#### Type of the changes
- [x] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation update
- [x] Tests improvement
- [ ] Refactoring

#### Checklist
- [x] The pull request has a description of the proposed change
- [x] I read the [Contributing
Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md)
before opening the pull request
- [x] The pull request uses **`develop`** as the base branch
- [x] Tests for the changes have been added
- [x] All new and existing tests passed

##### Additional steps for pull requests adding a new feature
- [ ] An issue describing the proposed change exists
- [ ] The pull request includes a link to the issue
- [ ] The change was discussed and approved in the issue
- [ ] Docs have been added / updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something was fixed 🎉 tests Add new tests or modify existing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants