tests: Refactor A2A test, bump Testcontainers, improve Awaitility extension & tests #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpavlov
force-pushed
the
kpavlov/a2a-docker
branch
from
9777d90 to
57867e5
Compare
kpavlov
added
the
refactoring
kpavlov
changed the title
kpavlov
requested review from
Ololoshechkin,
aozherelyeva,
sdubov and
skarpovdev
kpavlov
changed the title
sdubov
reviewed
Jan 8, 2026
a2a/a2a-client/src/jvmTest/kotlin/ai/koog/a2a/client/TestA2APythonServer.kt
Outdated
Show resolved
Hide resolved
a2a/a2a-client/src/jvmTest/kotlin/ai/koog/a2a/client/TestA2APythonServer.kt
Outdated
Show resolved
Hide resolved
a2a/a2a-client/src/jvmTest/kotlin/ai/koog/a2a/client/A2AClientJsonRpcIntegrationTest.kt
Show resolved
Hide resolved
a2a/a2a-client/src/jvmTest/kotlin/ai/koog/a2a/client/A2AClientJsonRpcIntegrationTest.kt
Show resolved
Hide resolved
kpavlov
force-pushed
the
kpavlov/a2a-docker
branch
6 times, most recently
from
0c32b03 to
bfefc85
Compare
aozherelyeva
approved these changes
Jan 8, 2026
…etup
- Removed `testcontainers-junit` dependency and replaced usage with direct `testcontainers` library.
- Don't build container in Gradle
- Upgraded `testcontainers` to the latest version.
- Refactored Python A2A server Docker handling into `TestA2APythonServer` object for cleaner test configuration.
2. Enhance Awaitility extensions to support return values
- Added support for returning values from `untilAsserted` extensions.
- Updated test cases to verify return value functionality.
3. Replace direct assertions with Awaitility in A2A tests
- Refactored tests to use Awaitility's coroutine extensions for asserting eventually consistent conditions.
- Simplified `sendMessageStreaming`, `resubscribeTask`, and notification configuration logic.
4. Use lazy/cached initialization for Docker availability check
kpavlov
force-pushed
the
kpavlov/a2a-docker
branch
from
f39a2da to
2771063
Compare
overfullstack
pushed a commit
to overfullstack/koog
that referenced
this pull request
Jan 11, 2026
…ension & tests (JetBrains#1338) Replace Testcontainers JUnit dependency and refactor Docker test setup 1. Replace Testcontainers JUnit dependency and refactor Docker test setup - Removed `testcontainers-junit` dependency and replaced usage with direct `testcontainers` library. - Don't build container in Gradle - Upgraded `testcontainers` to the latest version. - Refactored Python A2A server Docker handling into `TestA2AServerContainer` object for cleaner test configuration. 2. Enhance Awaitility extensions to support return values - Added support for returning values from `untilAsserted` extensions. - Updated test cases to verify return value functionality. 3. Replace direct assertions with Awaitility in A2A tests - Refactored tests to use Awaitility's coroutine extensions for asserting eventually consistent conditions. - Simplified `sendMessageStreaming`, `resubscribeTask`, and notification configuration logic. 4. Use lazy/cached initialization for Docker availability check ## Motivation and Context A2AClientJsonRpcIntegrationTest is flaky ## Breaking Changes No --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [x] Tests improvement - [x] Refactoring - [x] Dependency changes #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [ ] Tests for the changes have been added - [ ] All new and existing tests passed
vova-jb
pushed a commit
that referenced
this pull request
Jan 27, 2026
…ension & tests (#1338) Replace Testcontainers JUnit dependency and refactor Docker test setup 1. Replace Testcontainers JUnit dependency and refactor Docker test setup - Removed `testcontainers-junit` dependency and replaced usage with direct `testcontainers` library. - Don't build container in Gradle - Upgraded `testcontainers` to the latest version. - Refactored Python A2A server Docker handling into `TestA2AServerContainer` object for cleaner test configuration. 2. Enhance Awaitility extensions to support return values - Added support for returning values from `untilAsserted` extensions. - Updated test cases to verify return value functionality. 3. Replace direct assertions with Awaitility in A2A tests - Refactored tests to use Awaitility's coroutine extensions for asserting eventually consistent conditions. - Simplified `sendMessageStreaming`, `resubscribeTask`, and notification configuration logic. 4. Use lazy/cached initialization for Docker availability check ## Motivation and Context A2AClientJsonRpcIntegrationTest is flaky ## Breaking Changes No --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [x] Tests improvement - [x] Refactoring - [x] Dependency changes #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [ ] Tests for the changes have been added - [ ] All new and existing tests passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Testcontainers JUnit dependency and refactor Docker test setup
Replace Testcontainers JUnit dependency and refactor Docker test setup
testcontainers-junitdependency and replaced usage with directtestcontainerslibrary.testcontainersto the latest version.TestA2AServerContainerobject for cleaner test configuration.Enhance Awaitility extensions to support return values
untilAssertedextensions.Replace direct assertions with Awaitility in A2A tests
sendMessageStreaming,resubscribeTask, and notification configuration logic.Use lazy/cached initialization for Docker availability check
Motivation and Context
A2AClientJsonRpcIntegrationTest is flaky
Breaking Changes
No
Type of the changes
Checklist
developas the base branch