async docs: CB & promises - sp fix and clarifications #4690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "titled (sp) christmas tree" -> pyramid of doom - clarify promise description
clarify promise idea explainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the Callbacks section, there's a typo here:
**titled** christmas tree. I was going to fix totiltedand then decided to update that topyramid of doomsince that seemed more well-known.in the Promises/Futures section, the existing wording is unclear re: when the promise is returned:
we're promised that at some point it will return with an object called a Promise. So I clarified that with a few more words, aiming to keep existing simplicity without overcomplicating.