minor fix for typo, indent, link, comment #4714
Conversation
| @@ -74,7 +74,6 @@ For more information, see the corresponding sections below. | |||
| | [`compilerOpts`](#pass-compiler-and-linker-options) | Compiler options that the cinterop tool passes to the C compiler. | | |||
| | [`linkerOpts`](#pass-compiler-and-linker-options) | Linker options that the cinterop tool passes to the linker. | | |||
| | [`excludedFunctions`](#ignore-specific-functions) | A space-separated list of function names that should be ignored. | | |||
| | `excludedMacros` | | | |||
There was a problem hiding this comment.
JFYI
looks like this property is commented out in line 91
so I think it should be deleted here
docs/topics/null-safety.md
Outdated
| `person` or `person.department` is `null`, the function is not called. Here's the equivalent of the same safe call but with the `if` conditional: | ||
|
|
||
| ```kotlin | ||
| if (person != null && person.department != null) { | ||
| person.department.head = managersPool.getManager() | ||
| } | ||
| ``` |
There was a problem hiding this comment.
JFYI
I moved the Here's the equivalent ...... part here
I think it's better
docs/topics/whatsnew2020.md
Outdated
| @@ -27,7 +27,7 @@ See [Update to a new release](releases.md#update-to-a-new-kotlin-version) for de | |||
| Kotlin 2.0.20 begins to introduce changes to improve consistency in data classes and replace the Experimental context | |||
| receivers feature. | |||
|
|
|||
| ### Data class copy function to have the same visibility as constructor | |||
| ### Data class copy function will have the same visibility as constructor | |||
There was a problem hiding this comment.
JFYI
it is will have ... in line 8, so I changed it here too
There was a problem hiding this comment.
For the reviewer: keep the original title.
docs/topics/whatsnew21.md
Outdated
| // Branch with only the primary condition. Calls `feedDog()` when `animal` is `Dog` | ||
| is Animal.Dog -> animal.feedDog() | ||
| // Branch with both primary and guard conditions. Returns `feedCat()` when `Animal` is `Cat` and is not `mouseHunter` | ||
| // Branch with both primary and guard conditions. Calls `feedCat()` when `animal` is `Cat` and is not `mouseHunter` | ||
| is Animal.Cat if !animal.mouseHunter -> animal.feedCat() | ||
| // Returns "Unknown animal" if none of the above conditions match | ||
| // Prints "Unknown animal" if none of the above conditions match |
There was a problem hiding this comment.
JFYI
I think it should be Calls and Prints instead of Returns here
just like in control-flow.md
|
Hi @LiYing2010 |
sarahhaggarty
force-pushed
the
fix_for_typo
branch
from
62e0058 to
4a5a481
Compare
|
Hi @LiYing2010 ! Based on feedback from developers, I've accepted all changes except for those in these files:
And I added some minor modifications to these files:
Thank you so much for your contribution! Let me know if you have any questions. Apologies again for the confusion with PRs 🙏 |
|
@sarahhaggarty |
No description provided.