minor fix for typo, indent, link, comment #4714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiYing2010
commented
Feb 23, 2025
Comment on lines
-454
to
-455
| <a name="differences"/> | ||
|
|
There was a problem hiding this comment.
JFYI
the content which refer this link was deleted in commit ad3ebe2
so I think this link itself can be deleted to
LiYing2010
commented
Feb 23, 2025
| @@ -74,7 +74,6 @@ For more information, see the corresponding sections below. | |||
| | [`compilerOpts`](#pass-compiler-and-linker-options) | Compiler options that the cinterop tool passes to the C compiler. | | |||
| | [`linkerOpts`](#pass-compiler-and-linker-options) | Linker options that the cinterop tool passes to the linker. | | |||
| | [`excludedFunctions`](#ignore-specific-functions) | A space-separated list of function names that should be ignored. | | |||
| | `excludedMacros` | | | |||
There was a problem hiding this comment.
JFYI
looks like this property is commented out in line 91
so I think it should be deleted here
LiYing2010
commented
Feb 23, 2025
Comment on lines
+219
to
+225
| `person` or `person.department` is `null`, the function is not called. Here's the equivalent of the same safe call but with the `if` conditional: | ||
|
|
||
| ```kotlin | ||
| if (person != null && person.department != null) { | ||
| person.department.head = managersPool.getManager() | ||
| } | ||
| ``` |
There was a problem hiding this comment.
JFYI
I moved the Here's the equivalent ...... part here
I think it's better
LiYing2010
commented
Feb 23, 2025
| @@ -27,7 +27,7 @@ See [Update to a new release](releases.md#update-to-a-new-kotlin-version) for de | |||
| Kotlin 2.0.20 begins to introduce changes to improve consistency in data classes and replace the Experimental context | |||
| receivers feature. | |||
|
|
|||
| ### Data class copy function to have the same visibility as constructor | |||
| ### Data class copy function will have the same visibility as constructor | |||
There was a problem hiding this comment.
JFYI
it is will have ... in line 8, so I changed it here too
LiYing2010
commented
Feb 23, 2025
Comment on lines
+80
to
+84
| // Branch with only the primary condition. Calls `feedDog()` when `animal` is `Dog` | ||
| is Animal.Dog -> animal.feedDog() | ||
| // Branch with both primary and guard conditions. Returns `feedCat()` when `Animal` is `Cat` and is not `mouseHunter` | ||
| // Branch with both primary and guard conditions. Calls `feedCat()` when `animal` is `Cat` and is not `mouseHunter` | ||
| is Animal.Cat if !animal.mouseHunter -> animal.feedCat() | ||
| // Returns "Unknown animal" if none of the above conditions match | ||
| // Prints "Unknown animal" if none of the above conditions match |
There was a problem hiding this comment.
JFYI
I think it should be Calls and Prints instead of Returns here
just like in control-flow.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.