Skip to content

Conversation

@rpaouline
Copy link
Contributor

This helps the user know the type they are acting on, which would make it more obvious the user is acting on the wrong type.

#KT-73431

This helps the user know the type they are acting on, which would make it more obvious the user is acting on the wrong type.

#KT-73431
@rpaouline rpaouline requested review from a team, bnorm, cypressious, ligee and serras as code owners December 17, 2025 22:02
@rpaouline
Copy link
Contributor Author

There are two tests that need to be updated with this change:
FirPsiAssignmentPluginDiagnosticTestGenerated. testOtherOperators()
FirPsiAssignmentPluginDiagnosticTestGenerated. testPlusAssignPrecedence()

Can you update them too? I'm not familiar with the test generator format that creates them

@mglukhikh
Copy link
Contributor

From my side I'd recommend to add at least one test that shows how a new message looks like. There are two ways to do it:

  • manually change a tag <!UNRESOLVED_REFERENCE!>something<!> to <!UNRESOLVED_REFERENCE("")!>something<!> in some of .kt or .fir.kt diagnostic test files, then run the corresponding test and the rest runner will suggest to add diagnostic parameters into ""
  • or, you can add // RENDER_DIAGNOSTICS_FULL_TEXT directive at top of some diagnostic tests, then the test runner will generate additional file with diagnostic full text for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants