[KT-83620] Exclude project structure metadata from inputs when projec… #5624
+28
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t dependencies are ignored `MetadataDependencyTransformationTaskInputs` was unconditionally adding project structure metadata as an input. However, when `keepProjectDependencies` is false (e.g. for the IDE CInterop task), these dependencies are not used. This change ensures `projectStructureMetadataFileCollection` is empty when `keepProjectDependencies` is false. Test: CInteropMetadataDependencyTransformationTaskTest
Contributor
|
/test-private |
|
Command rejected: Command cannot be used on a branch from forked repository. |
Contributor
|
I think I should cherry-pick your changes to my branch and merge from there. |
Contributor
|
Ok it doesn't seem to be an innocent change, lots of tests start to fail with this. I'll investigate them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t dependencies are ignored
MetadataDependencyTransformationTaskInputswas unconditionally adding project structure metadata as an input. However, whenkeepProjectDependenciesis false (e.g. for the IDE CInterop task), these dependencies are not used. This change ensuresprojectStructureMetadataFileCollectionis empty whenkeepProjectDependenciesis false.Test: CInteropMetadataDependencyTransformationTaskTest