Add caches to callers of JvmDependenciesIndex #5627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For context, see https://youtrack.jetbrains.com/issue/KT-83191. This CL adds Guava CacheBuilder to `CliVirtualFileFinder` and `KotlinCliJavaFileManagerImpl` to cache the relevant files in a given package across all roots/jars. This can drastically improve build performance for cases with a large number of roots/jars that have overlapping packages.
demiurg906
requested review from
mglukhikh
and removed request for
demiurg906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, see https://youtrack.jetbrains.com/issue/KT-83191.
This CL adds Guava CacheBuilder to
CliVirtualFileFinderandKotlinCliJavaFileManagerImpl. These caches map the package name to the children in the package across all roots/jars and avoids having to iterate through all jars on subsequent calls. This can drastically improve build performance for cases with a large number of roots/jars that have overlapping packages.