[Klib] Rework serialization logic for IrTypeAlias#6500
Open
Miłosz Piekutowski (mpiekutowski) wants to merge 4 commits into
Open
[Klib] Rework serialization logic for IrTypeAlias#6500Miłosz Piekutowski (mpiekutowski) wants to merge 4 commits into
IrTypeAlias#6500Miłosz Piekutowski (mpiekutowski) wants to merge 4 commits into
Conversation
Code Owners
|
Drop serialization and deserialization of `IrTypeAlias`, keep the proto field for backward compatibility. ^KT-86632 Fixed
Miłosz Piekutowski (mpiekutowski)
force-pushed
the
rr/milo/KT-86632/fix
branch
from
5540455 to
e9f6dc5
Compare
Miłosz Piekutowski (mpiekutowski)
requested review from
Dmitriy Dolovov (ddolovov) and
Nikolay Lunyak (lunakoly)
Comment on lines
1562
to
1565
| is IrTypeAlias -> | ||
| proto.irTypeAlias = serializeIrTypeAlias(declaration, parent) | ||
| error("IrTypeAlias must not be serialized") | ||
| else -> | ||
| TODO("Declaration serialization not supported yet: $declaration") |
Contributor
There was a problem hiding this comment.
I would probably merge the branch for is IrTypeAlias with else and replace TODO("Declaration serialization not supported yet: $declaration") by error("Serialization of ${declaration::class.java} is not supported: $declaration")
Contributor
|
It makes sense to add a flag to |
| * As a much simpler approach, fake overrides in local classes are not dumped both before and after serialization. | ||
| */ | ||
| true | ||
| } else if (declaration is IrTypeAlias) { |
Contributor
There was a problem hiding this comment.
if (declaration is IrTypeAlias && !isAfterDeserialization) ?
Dmitriy Dolovov (ddolovov)
requested changes
Jul 3, 2026
Review suggestions
klib tool flag
Miłosz Piekutowski (mpiekutowski)
requested a review
from Dmitriy Dolovov (ddolovov)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backward/Forward Compatibility run: https://buildserver.labs.intellij.net/buildConfiguration/Kotlin_KotlinDev_KlibBackwardAndForwardCompatibilityTestsNightly/992859318
(All failures inherited from master branch)