[Analysis API] Ignore missing standalone binary roots#6506
Open
Maxerns wants to merge 1 commit into
Open
Conversation
Standalone Analysis API asks the IntelliJ jar file system for every archive root while building library roots. Missing jar paths can make that lookup throw before downstream tools get a chance to report their own classpath warning. Skip missing archive roots before opening them through the jar file system, matching the graceful behavior expected by tools which intentionally pass unresolved classpath entries. Add a session builder regression test for a missing binary jar root. ^KT-57715 Fixed
Code Owners
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes KT-57715.
Standalone Analysis API could throw when a missing
.jar/.klibbinary root was passed to the session builder, because the jar VFS was
queried before checking whether the path exists.
This skips missing archive roots before opening them through the jar
file system and adds a regression test for a missing binary jar root.
Tests:
./gradlew :analysis:analysis-api-standalone:compileTestKotlin -q./gradlew :analysis:analysis-api-standalone:test --tests "org.jetbrains.kotlin.analysis.api.standalone.fir.test.cases.session.builder.StandaloneSessionBuilderTest.testMissingBinaryRootDoesNotCrashStandaloneSessionBuilder"CC: Yan Zhulanow (@yanex) Marco Pennekamp (@marcopennekamp) Alexey Belkov (@abelkov) Dmitrii Gridin (@dimonchik0036) Oleg Makeev (@BlaBlaHuman)