[Klib] Use DuplicatedUniqueNameStrategy.ALLOW_ALL in metadata compilation by mcpiroman · Pull Request #6511 · JetBrains/kotlin

Wojciech Litewka (mcpiroman) · 2026-07-02T16:42:41Z

No description provided.

…amesTest The test used to verify warning and error messages in case the compilation failed, but it should also check whether the compilation was supposed to fail at all. KT-77818

Unlike other available modes, it does not result in any error or warning. KT-77818

…tion #KT-77818 Fixed

kotlin-safemerge · 2026-07-02T16:42:47Z

Code Owners

Rule	Owners	Approval
`/compiler/arguments/resources/kotlin-compiler-arguments.json`	build-tools-api `wojtek-kalicinski` `ALikhachev` `Herudaio` `ywett02` `shinkai-tester` (QA) kotlin-build-tools `AYastrebov` `Egorand` `Tapchicoma` `antohaby` `Herudaio` `atyrin` (QA) `timofeys1` `nav-nav` `CherepanovAleksei` `rbbozkurt` `shinkai-tester` (QA) `viakunin` `ksiarhey` `levchenkoin` (QA) `adam-enko` kotlin-frontend `ligee` `bnorm` `mglukhikh` `KvanTTT` `cypressious` `demiurg906` `FenstonSingel` (QA) `lunakoly` `paganma` `GrigoriiSolnyshkin` `Aleksandra-Arsenteva` (QA) kotlin-wasm `bashor` `karlosz` `ilgonmic` `jmrtsh` `igoriakovlev` `alex28sh`	✅ `demiurg906` 🔒
`/compiler/arguments/`	build-tools-api `wojtek-kalicinski` `ALikhachev` `Herudaio` `ywett02` `shinkai-tester` (QA) kotlin-build-tools `AYastrebov` `Egorand` `Tapchicoma` `antohaby` `Herudaio` `atyrin` (QA) `timofeys1` `nav-nav` `CherepanovAleksei` `rbbozkurt` `shinkai-tester` (QA) `viakunin` `ksiarhey` `levchenkoin` (QA) `adam-enko` kotlin-frontend `ligee` `bnorm` `mglukhikh` `KvanTTT` `cypressious` `demiurg906` `FenstonSingel` (QA) `lunakoly` `paganma` `GrigoriiSolnyshkin` `Aleksandra-Arsenteva` (QA)	✅ `demiurg906` 🔒
`/compiler/build-tools/kotlin-build-tools-api/api/kotlin-build-tools-api.api`, `/compiler/build-tools/kotlin-build-tools-api/gen/`	kotlin `klikh` `antonarhipov` `singleton11` `AYastrebov` `wojtek-kalicinski` `Egorand` `ALikhachev` `shengyou` `svtk` `Tapchicoma` `joffrey-bion` `SebastianAigner` `qwwdfsad` `antohaby` `eupp` `ilya-g` `murfel` `shanshin` `abarsov` `pahill` `Herudaio` `atyrin` (QA) `timofeys1` `DmitryNekrasov` `vmishenev` `EmilFlach` `sandwwraith` `zsmb13` `nomisRev` `utikeev` `fzhinkin` `AbdullinAM` `ywett02` `strangepleasures` `nav-nav` `Jeffset` `CherepanovAleksei` `solarday` (QA) `frederikpietzko` `sellmair` `rbbozkurt` `whyoleg` `shinkai-tester` (QA) `d-ambatenne` `viakunin` `ksiarhey` `Daria-Voronina` `levchenkoin` (QA) `adam-enko` kotlin-compiler `sbogolepov` `kunyavskiy` `ykantor` kotlin-frontend `ligee` `bnorm` `mglukhikh` `KvanTTT` `cypressious` `demiurg906` `FenstonSingel` (QA) `lunakoly` `paganma` `GrigoriiSolnyshkin` `Aleksandra-Arsenteva` (QA) kotlin-wasm `bashor` `karlosz` `ilgonmic` `jmrtsh` `igoriakovlev` `alex28sh` kotlin-jvm `udalov` `ilmirus` `grechkovlad` `MaxVerevkin` `jkurys2` `zhelenskiy` `aShalygin` (QA) kotlin-js `JSMonk` `broadwaylamb` `seclerp` kotlin-common-backend `vsukharev` `ivandev0` `AnzhelaSukhanova` (QA) `mcpiroman` `ddolovov` `mpiekutowski` kotlin-native `mMaxy` `projedi` `anton-bannykh` `DmT021` `haitaka` `glukianets` `azakharenko` `homuroll` `SvyatoslavScherbina` `OlgaSemakina` (QA) `zeks07` kotlin-language-evolution `serras` `jesyspa` `ice-phoenix` `zarechenskiy` `watc4d0gg` `FenstonSingel` (QA) `InversionSpaces` `e2e4b6b7`	🔴 `ddolovov`
`/compiler/cli/`, `/compiler/config/`	kotlin-frontend `ligee` `bnorm` `mglukhikh` `KvanTTT` `cypressious` `demiurg906` `FenstonSingel` (QA) `lunakoly` `paganma` `GrigoriiSolnyshkin` `Aleksandra-Arsenteva` (QA)	✅ `demiurg906` 🔒
`/compiler/ir/serialization.common/`, `/compiler/util-klib-metadata/`, `/native/native.tests/klib-ir-inliner/`	kotlin-common-backend `vsukharev` `ivandev0` `AnzhelaSukhanova` (QA) `mcpiroman` `ddolovov` `mpiekutowski`	🔴 `ddolovov`

Dmitriy Novozhilov (demiurg906)

/final

Dmitriy Dolovov (ddolovov) · 2026-07-03T12:26:21Z


+    @Test
+    fun `Regular compilation - ALLOW_ALL strategy`() = runTest(
+        strategy = DuplicatedUniqueNameStrategy.ALLOW_ALL_WITH_WARNING,


There should be ALLOW_ALL, right?

Wojciech Litewka (mcpiroman) added 3 commits July 2, 2026 18:38

[Klib][Tests] Check if compilation passed in KlibCliDuplicatedUniqueN…

5dd7e7e

…amesTest The test used to verify warning and error messages in case the compilation failed, but it should also check whether the compilation was supposed to fail at all. KT-77818

[Klib] Add DuplicatedUniqueNameStrategy.ALLOW_ALL mode

d2f7c4c

Unlike other available modes, it does not result in any error or warning. KT-77818

[Klib] Use DuplicatedUniqueNameStrategy.ALLOW_ALL in metadata compila…

c52fb76

…tion #KT-77818 Fixed

Wojciech Litewka (mcpiroman) requested review from Dmitriy Dolovov (ddolovov) and Dmitriy Novozhilov (demiurg906) July 2, 2026 16:43

Dmitriy Novozhilov (demiurg906) approved these changes Jul 3, 2026

View reviewed changes

Dmitriy Dolovov (ddolovov) reviewed Jul 3, 2026

View reviewed changes

Dmitriy Dolovov (ddolovov) requested changes Jul 3, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Klib] Use DuplicatedUniqueNameStrategy.ALLOW_ALL in metadata compilation#6511

[Klib] Use DuplicatedUniqueNameStrategy.ALLOW_ALL in metadata compilation#6511
Wojciech Litewka (mcpiroman) wants to merge 3 commits into
masterfrom
wlitewka/fix-unique-name-warn-for-metadata-klib

Wojciech Litewka (mcpiroman) commented Jul 2, 2026

Uh oh!

kotlin-safemerge Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

Dmitriy Novozhilov (demiurg906) left a comment

Uh oh!

Dmitriy Dolovov (ddolovov) Jul 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Wojciech Litewka (mcpiroman) commented Jul 2, 2026

Uh oh!

kotlin-safemerge Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Owners

Uh oh!

Dmitriy Novozhilov (demiurg906) left a comment

Choose a reason for hiding this comment

Uh oh!

Dmitriy Dolovov (ddolovov) Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kotlin-safemerge Bot commented Jul 2, 2026 •

edited

Loading