[PSI] Add org.jetbrains.annotations.NotNull to properties in KtTokens.java and KtNodeTypes.java#6512
Conversation
Currently, from `something?.token == KtTokens.SOME_TOKEN` our logic system deduces that `something != null` although `KtTokens.SOME_TOKEN` is flexible and from type system POV can be null. In the scope of KT-87278 we'd like to prohibit this under LF. Affected places in kotlin.git are due to usage of properties from `KtTokens` or `KtNodeTypes`. Hence, we annotate them here with nullability annotations.
Currently, from `something?.token == KtTokens.SOME_TOKEN` our logic system deduces that `something != null` although `KtTokens.SOME_TOKEN` is flexible and from type system POV can be null. In the scope of KT-87278 we'd like to prohibit this under LF. Affected places in kotlin.git are due to usage of properties from `KtTokens` or `KtNodeTypes`. Hence, we annotate them here with nullability annotations.
|
This merge request potentially modifies the stubs format, but doesn't update |
Grigorii Solnyshkin (GrigoriiSolnyshkin)
requested a review
from Yan Zhulanow (yanex)
|
/dry-run |
|
THIS IS A DRY RUN Quality gate is triggered at https://buildserver.labs.intellij.net/build/991991038 — use this link to get full insight. Quality gate was triggered with the following revisions:
Quality gate failed. See https://buildserver.labs.intellij.net/build/991991038 to get full insight. |
|
JIC: the hits can be found here #6501 |
Grigorii Solnyshkin (GrigoriiSolnyshkin)
requested a review
from Nikolay Lunyak (lunakoly)
|
Let's do this for |
Previous commits did this for `KtTokens.java` and `KtNodeTypes.java`. For consistency, it makes sense to do the same for `KDocTokens.java`.
4 participants
No description provided.