Skip to content

Align version constants with the current KotlinVersion#6519

Open
Ivan Kochurkin (KvanTTT) wants to merge 5 commits into
masterfrom
ikochurkin/versions-fixes
Open

Align version constants with the current KotlinVersion#6519
Ivan Kochurkin (KvanTTT) wants to merge 5 commits into
masterfrom
ikochurkin/versions-fixes

Conversation

@KvanTTT

@KvanTTT Ivan Kochurkin (KvanTTT) commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

I've noticed that we've been changing some constants on every LV update and some version can be aligned with the KotlinVersion.CURRENT.

It could be useful to have before merging #6097 and for future version updates.

Feel free to use only particular commits that you consider useful.

@kodee-bot

kodee-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

Hi! It looks like there are no references to any YT issues in the commit messages.
If the change is non-functional, feel free to ignore the comment :)
Otherwise, please add them as requested in the guideline.

@KvanTTT

Copy link
Copy Markdown
Contributor Author

/dry-run

@kotlin-safemerge

Copy link
Copy Markdown

Failed to process command due to an unexpected exception.

@KvanTTT

Copy link
Copy Markdown
Contributor Author

/dry-run

@kotlin-safemerge

Copy link
Copy Markdown

Failed to process command due to an unexpected exception.

* Since the release of 2.2.0, the ABI version is aligned with the Kotlin version.
*/
val CURRENT = KotlinAbiVersion(2, 4, 0)
val CURRENT = KotlinAbiVersion(KotlinVersion.CURRENT.major, KotlinVersion.CURRENT.minor, 0)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDEA opens a file from a jar when I try opening a definition of KotlinVersion.CURRENT that's initialized with 2.2.21 instead of the actual local 2.4.255. But it looks like a resolving bug because I have KotlinAbiVersion.CURRENT = 2.4.0 in runtime.

@ice-phoenix Marat Akhin (ice-phoenix) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/final

@ivandev0 Ivan Kylchik (ivandev0) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/final

@ivandev0

Copy link
Copy Markdown
Contributor

cc Dmitriy Dolovov (@ddolovov) FYI

@KvanTTT

Copy link
Copy Markdown
Contributor Author

/dry-run

@KotlinBuild

This comment has been minimized.

It's always aligned with `KotlinVersion` (at least since Kotlin 1.6.0)
according to its updating throughout git history.

Simplify language-to-metadata version mapping.
@ddolovov

Copy link
Copy Markdown
Contributor

Ivan Kochurkin (@KvanTTT) Have you checked if this breaks org.jetbrains.kotlin.konan.test.abi.AbiVersionTest when compiling with the bumped Kotlin version?

According to its KDoc: "Since the release of 2.2.0, the ABI version is aligned with the Kotlin version."
…KotlinVersion`

It's always aligned with `KotlinVersion`
according to its updating throughout git history.
@KvanTTT

Copy link
Copy Markdown
Contributor Author

/dry-run

@KotlinBuild

Build Server (KotlinBuild) commented Jul 4, 2026

Copy link
Copy Markdown

THIS IS A DRY RUN

Quality gate is triggered at https://buildserver.labs.intellij.net/build/993877877 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-6519/safe-merge
Commit: 90ac775


Quality gate failed. See https://buildserver.labs.intellij.net/build/993877877 to get full insight.

@KvanTTT

Ivan Kochurkin (KvanTTT) commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Have you checked if this breaks org.jetbrains.kotlin.konan.test.abi.AbiVersionTest when compiling with the bumped Kotlin version?

Yes, it looks like they are fine (I rebased the branch on the latest master and relaunched /dry-run). The thing that is not fine is Align `CURRENT` in `MetadataVersion` with the current `KotlinVersion because some third-party tests are failing: https://buildserver.labs.intellij.net/buildConfiguration/Kotlin_KotlinDev_Aggregate/993276250 I reverted this change in !fixup commit and those tests seems were fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants