Align version constants with the current KotlinVersion#6519
Align version constants with the current KotlinVersion#6519Ivan Kochurkin (KvanTTT) wants to merge 5 commits into
KotlinVersion#6519Conversation
|
Hi! It looks like there are no references to any YT issues in the commit messages. |
Code Owners
|
|
/dry-run |
|
Failed to process command due to an unexpected exception. |
|
/dry-run |
|
Failed to process command due to an unexpected exception. |
| * Since the release of 2.2.0, the ABI version is aligned with the Kotlin version. | ||
| */ | ||
| val CURRENT = KotlinAbiVersion(2, 4, 0) | ||
| val CURRENT = KotlinAbiVersion(KotlinVersion.CURRENT.major, KotlinVersion.CURRENT.minor, 0) |
There was a problem hiding this comment.
IDEA opens a file from a jar when I try opening a definition of KotlinVersion.CURRENT that's initialized with 2.2.21 instead of the actual local 2.4.255. But it looks like a resolving bug because I have KotlinAbiVersion.CURRENT = 2.4.0 in runtime.
Marat Akhin (ice-phoenix)
left a comment
There was a problem hiding this comment.
/final
|
cc Dmitriy Dolovov (@ddolovov) FYI |
|
/dry-run |
This comment has been minimized.
This comment has been minimized.
It's always aligned with `KotlinVersion` (at least since Kotlin 1.6.0) according to its updating throughout git history. Simplify language-to-metadata version mapping.
|
Ivan Kochurkin (@KvanTTT) Have you checked if this breaks |
According to its KDoc: "Since the release of 2.2.0, the ABI version is aligned with the Kotlin version."
…KotlinVersion` It's always aligned with `KotlinVersion` according to its updating throughout git history.
648e155 to
9cf56ea
Compare
|
/dry-run |
|
THIS IS A DRY RUN Quality gate is triggered at https://buildserver.labs.intellij.net/build/993877877 — use this link to get full insight. Quality gate was triggered with the following revisions:
Quality gate failed. See https://buildserver.labs.intellij.net/build/993877877 to get full insight. |
Yes, it looks like they are fine (I rebased the branch on the latest master and relaunched |
I've noticed that we've been changing some constants on every LV update and some version can be aligned with the
KotlinVersion.CURRENT.It could be useful to have before merging #6097 and for future version updates.
Feel free to use only particular commits that you consider useful.