[Tests][JS] Ignore two tests with ES_MODULE in JS Klib forward compatibility testing.#6530
Open
Vladimir Sukharev (vsukharev) wants to merge 1 commit into
Open
Conversation
|
|
d955a35 to
fc566ae
Compare
Contributor
Author
|
Nightly CI configuration is triggered to check this PR. These two tests are fixed there: https://buildserver.labs.intellij.net/buildConfiguration/Kotlin_KotlinDev_KlibBackwardAndForwardCompatibilityTestsNightly/994266365 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In scope of KT-75176 Add infrastructure for bundle size testing, the following tests were enabled for JS_IR using ES_MODULES:
In presence of ES_MODULES test directive, JS testing fails in multi-module mode, which is highlighted by test directive and comment:
Similarly, in Klib forward compatibility tests there is no re-exports from the dependencies, so it's failing with a runtime error, that there is no expected exported function.
These two failures are revealed in recent CI run https://buildserver.labs.intellij.net/buildConfiguration/Kotlin_KotlinDev_KlibBackwardAndForwardCompatibilityTestsNightly/994159326
In this PR, these two tests are ignored for JS Klib forward compatibility tests