Skip to content

[Tests][JS] Ignore two tests with ES_MODULE in JS Klib forward compatibility testing.#6530

Open
Vladimir Sukharev (vsukharev) wants to merge 1 commit into
masterfrom
sukharev/ignore-two-tests-with-es-modules
Open

[Tests][JS] Ignore two tests with ES_MODULE in JS Klib forward compatibility testing.#6530
Vladimir Sukharev (vsukharev) wants to merge 1 commit into
masterfrom
sukharev/ignore-two-tests-with-es-modules

Conversation

@vsukharev

@vsukharev Vladimir Sukharev (vsukharev) commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

In scope of KT-75176 Add infrastructure for bundle size testing, the following tests were enabled for JS_IR using ES_MODULES:

  • compiler/testData/codegen/box/size/helloWorldPromise.kt
  • compiler/testData/codegen/box/size/add.kt

In presence of ES_MODULES test directive, JS testing fails in multi-module mode, which is highlighted by test directive and comment:

// IGNORE_BACKEND_K2_MULTI_MODULE: JS_IR, JS_IR_ES6
// ^^^^^^
// The Mutli Module tests are compiling the main module as a dependency module.
// Since we use ES modules in those tests, there is no re-exports from the dependencies,
// so it's failing with a runtime error, that there is no expected exported function

Similarly, in Klib forward compatibility tests there is no re-exports from the dependencies, so it's failing with a runtime error, that there is no expected exported function.
These two failures are revealed in recent CI run https://buildserver.labs.intellij.net/buildConfiguration/Kotlin_KotlinDev_KlibBackwardAndForwardCompatibilityTestsNightly/994159326

In this PR, these two tests are ignored for JS Klib forward compatibility tests

@kotlin-safemerge

kotlin-safemerge Bot commented Jul 5, 2026

Copy link
Copy Markdown

Code Owners

RuleOwnersApproval
/​compiler/​testData/​codegen/​box/​size/​bashor
kotlin-js

JSMonk

@kodee-bot

kodee-bot Bot commented Jul 5, 2026

Copy link
Copy Markdown

Hi! It looks like there are no references to any YT issues in the commit messages.
If the change is non-functional, feel free to ignore the comment :)
Otherwise, please add them as requested in the guideline.

@vsukharev Vladimir Sukharev (vsukharev) force-pushed the sukharev/ignore-two-tests-with-es-modules branch from d955a35 to fc566ae Compare July 5, 2026 07:43
@vsukharev

Vladimir Sukharev (vsukharev) commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Nightly CI configuration is triggered to check this PR. These two tests are fixed there: https://buildserver.labs.intellij.net/buildConfiguration/Kotlin_KotlinDev_KlibBackwardAndForwardCompatibilityTestsNightly/994266365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant