[Tests][JS] Don't use codegen helpers for JS diagnostic tests#6531
Open
Vladimir Sukharev (vsukharev) wants to merge 1 commit into
Open
Conversation
Code Owners
|
otherwise, KOTLIN_PACKAGE_USAGE error diagnostic will be raised for helpers fail.kt, asserts.kt, arrayAsserts.kt, ^KT-85764
3eb9ce4 to
aa6f6dd
Compare
|
|
||
| // Adapter should be initialized eagerly | ||
| @Suppress("INVISIBLE_MEMBER") | ||
| @Suppress("INVISIBLE_MEMBER", "INVISIBLE_REFERENCE") |
Contributor
Author
There was a problem hiding this comment.
This suppress is now needed due to added NoFirCompilationErrorsHandler via commonFirHandlersForCodegenTest()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't use codegen helpers for JS diagnostic tests,
otherwise, KOTLIN_PACKAGE_USAGE error diagnostic will be raised for helpers
fail.kt,asserts.kt,arrayAsserts.kt, which contain linepackage kotlin, which isRationale: in master,
JsDiagnosticsWithIrInlinerTestGenerated,LightTreeJsKlibDiagnosticsTestGeneratedandPsiJsKlibDiagnosticsTestGeneratedare red with messagesIt isn't shown in Aggregate CI, due to exclusion of JS ES5 tests from Aggregate CI, in scope of
KTI-3244 Duty (18 May - 24 May) .
See
Due to absence in Aggregate, these testrunners were overlooked in scope of ^KT-85764.
This PR fixes them by removing the following codegen helpers from JS diagnostic tests, and adding them only to JS codegen tests:
JsAdditionalSourceProviderCoroutineHelpersSourceFilesProviderOn the way, abstract classes for ES6 codegen tests were streamlined
Note: As next steps, it worth returning ES5 testrunners to Aggregate CI, due to upcoming 2.4.20-Beta2 branching.
^KT-85764