[Gradle] Delete KotlinSourceSet.implementationMetadataConfigurationName - #7605
Conversation
^KT-80897 Verification Pending
Code Owners
PR commands for maintainers
|
Timofey Solonin (timofeys1)
left a comment
Timofey Solonin (timofeys1)
left a comment
There was a problem hiding this comment.
/final
| /** | ||
| * @suppress | ||
| */ | ||
| @Deprecated(message = "KT-80897. Keep ABI compatibility with kotlinx-benchmarks", level = DeprecationLevel.HIDDEN) |
There was a problem hiding this comment.
kotlinx-benchmark does not reference this API anymore (commit that removed the callsite) since 0.4.15 (latest version is 0.4.17).
There was a problem hiding this comment.
I think you might still not be able to remove it because coroutines seems to still use 0.4.13
There was a problem hiding this comment.
If that's the case, you will need to bump the version in coroutines and then whether we can remove this depend on where exactly the benchmarks were used
There was a problem hiding this comment.
Hmm, yeah, we had a similar issue with kotlinx.collections.immutable: https://jetbrains.slack.com/archives/C06QB5UHN9Y/p1787063796944369?thread_ts=1787058758.326779&cid=C06QB5UHN9Y. Let me try to bump the version in coroutines and see if it builds with the latest benchmarks.
There was a problem hiding this comment.
Stopped safe-merge job for now while I investigate.
There was a problem hiding this comment.
|
/safe-merge |
This comment has been minimized.
This comment has been minimized.
|
/safe-merge |
|
Quality gate is triggered at https://buildserver.labs.intellij.net/build/1036959519 — use this link to get full insight. Quality gate was triggered with the following revisions:
Triggered a retry attempt №1 out of 1. Quality gate failed. See https://buildserver.labs.intellij.net/build/1036959519 to get full insight. |
3 participants
^KT-80897 Verification Pending